Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing compilation flags using spec_wrapper #211

Open
missing-user opened this issue Nov 22, 2024 · 1 comment
Open

Missing compilation flags using spec_wrapper #211

missing-user opened this issue Nov 22, 2024 · 1 comment

Comments

@missing-user
Copy link
Contributor

missing-user commented Nov 22, 2024

I noticed, that SPEC was significantly slower when running from simsopt than standalone. Looking closer, the shared object Library produced when compiling spec_wrapper doesn't utilize the same compilation flags, e. g. -O3.

When running the initialization from the spec wrapper, the console output also indicates no compilation flags were passed.

       :            : fc      = /usr/bin/mpifort ; 
       :            : flags   =  ; 

I think we should fix spec_wrapper/CmakeLists.txt to at least enable ftree-vectorize, such that xspec standalone and the Python bindings behave the same.

@missing-user missing-user changed the title Performance issues using spec_wrapper Missing compilation flags using spec_wrapper Nov 26, 2024
@missing-user
Copy link
Contributor Author

The question was promted because I noticed that some parts of SPEC were running on one thread, eventho they should have been OMP parallel (e.g. poincare, virtual casing)
After a discussion with @smiet it seems like this is specific to GCC and works fine with the Intel compiler. The missing compilation flags should be added to the call to f2py in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant