Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test matchers are equal, potential for false positives #15

Open
DoctorHowser opened this issue Oct 3, 2023 · 1 comment
Open

Test matchers are equal, potential for false positives #15

DoctorHowser opened this issue Oct 3, 2023 · 1 comment
Assignees
@christopher-black

Comments

@DoctorHowser
Copy link
Contributor

DoctorHowser commented Oct 3, 2023 •
edited
Loading

Tests want Try again later. vs failing with Try again later
expect(diceRoll).to.equal('Try again later.'); vs
expect(diceRoll).toMatch(/Try again later/i);

This may require some adjustment?
@christopher-black
Copy link
Contributor

I agree. These tests should be more flexible and pass even if the punctuation is missing.

sschulte24110 added a commit to sschulte24110/eda-pw-week-2-assignment-part-1 that referenced this issue Mar 28, 2024
@sschulte24110
Update on aboutMe.js.
9853835 
Changes on the code for Stretch Goals PrimeAcademy#15.
Changes on some of the console.logs so they contain more info and are
    easier to understand when looking at the console.
AndrewZajac added a commit to AndrewZajac/eda-pw-week-2-assignment-part-1 that referenced this issue Mar 31, 2024
@AndrewZajac
Strectch goals PrimeAcademy#15 and 16 are done, code formatter for be…
b318bd9 
…auty added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christopher-black christopher-black

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DoctorHowser @christopher-black