-
Notifications
You must be signed in to change notification settings - Fork 477
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module naming conventions should allow underscore #1722
Comments
+1 I never understood who came with this thing, completely breaking the ecosystem and conventions. (If native modules were not prefixed with ps_ than maybe. :-)) Related to PrestaShop/PrestaShop#23717 |
I really hope we can sort this out one way or another 🙂 And for what? I also agree with @Hlavtox comment about convention. AFAIK there was no module naming convention before, so back in time, I just read between the lines that one should use underscores, such as using company_module, just like the native ps_modules did and still does. And I still think that should be the convention 😉 I understand there might be some technical issues with translation domains, but I think maybe it no longer is the case? |
In devdocs Module naming convention it is stated that:
I suggest that the convention instead should be something like:
ps_
. This makes it easier to avoid conflicts in module name collisions , allowing the merchant to both have (example) modulespsdevone_imageslider
as well aspsdevtwo_imageslider
andps_imageslider
.Why allow underscores?
much_easier_to_read
thannotusingunderscoresatall
, in file-lists, databases and where ever.Also discussed on slack
The text was updated successfully, but these errors were encountered: