You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are many places in the codebase where we modify what's in $_POST. This is a bad practice that can have unpredictable side effects. Instead, we should get content out of $_POST as needed, and in cases where we need to modify params submitted in the POST body, we should parse them into a local variable.
The text was updated successfully, but these errors were encountered:
This mostly happens in the NominateThisEndpoint class, because it then calls nominate_it(), and the latter method is built to look at the superglobal. The business logic should be abstracted into its own method so that we can avoid the $_POST overwriting. But I don't fully understand the nomination endpoint, other than to understand that it's intended for use with the Chrome extension. As such, I'm going to set this task aside for some future round of development.
There are many places in the codebase where we modify what's in
$_POST
. This is a bad practice that can have unpredictable side effects. Instead, we should get content out of$_POST
as needed, and in cases where we need to modify params submitted in the POST body, we should parse them into a local variable.The text was updated successfully, but these errors were encountered: