Update tests to reflect need to enable rule

liamjpeters · liamjpeters · commit 7a82c616d3bb · 2026-02-01T14:41:03.000Z
diff --git a/Tests/Rules/UseConsistentParameterSetName.tests.ps1 b/Tests/Rules/UseConsistentParameterSetName.tests.ps1
@@ -3,6 +3,14 @@
 
 BeforeAll {
     $ruleName = 'PSUseConsistentParameterSetName'
+
+    $ruleSettings = @{
+        Enable = $true
+    }
+    $settings = @{
+        IncludeRules = @($ruleName)
+        Rules        = @{ $ruleName = $ruleSettings }
+    }
 }
 
 Describe "UseConsistentParameterSetName" {
@@ -20,7 +28,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Severity | Should -Be 'Warning'
             $violations[0].Message | Should -Match "DefaultParameterSetName 'SetOne' does not match the case of ParameterSetName 'setone'"
@@ -39,7 +47,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2
             $violations | ForEach-Object { $_.Severity | Should -Be 'Warning' }
         }
@@ -62,7 +70,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Severity | Should -Be 'Warning'
             $violations[0].Message | Should -Match "ParameterSetName 'setone' does not match the case of 'SetOne'"
@@ -83,7 +91,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2  # Two mismatches with the first occurrence
             $violations | ForEach-Object { $_.Severity | Should -Be 'Warning' }
         }
@@ -103,7 +111,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Severity | Should -Be 'Warning'
             $violations[0].Message | Should -Match "uses parameter sets but does not specify a DefaultParameterSetName"
@@ -121,7 +129,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2
             $violations | ForEach-Object { $_.Message | Should -Be "Parameter 'Parameter1' is declared in parameter-set 'SetOne' multiple times." }
         }
@@ -136,7 +144,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2
             $violations | ForEach-Object { $_.Message | Should -Be "Parameter 'Parameter1' is declared in parameter-set '__AllParameterSets' multiple times." }
         }
@@ -151,7 +159,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2
             $violations | ForEach-Object { $_.Message | Should -Be "Parameter 'Parameter1' is declared in parameter-set '__AllParameterSets' multiple times." }
         }
@@ -169,7 +177,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Message | Should -Match "should not contain new lines"
         }
@@ -183,7 +191,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Message | Should -Match "should not contain new lines"
         }
@@ -197,7 +205,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
         }
 
@@ -210,7 +218,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Message | Should -Match "should not contain new lines"
         }
@@ -224,7 +232,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
             $violations[0].Message | Should -Match "should not contain new lines"
         }
@@ -237,7 +245,7 @@ function Test-Function {
     param([string]$Parameter1)
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 1
         }
 
@@ -253,7 +261,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -267,7 +275,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -284,7 +292,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -304,7 +312,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -323,7 +331,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -339,7 +347,7 @@ function Test-Function {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
     }
@@ -362,7 +370,7 @@ function Test-ComplexFunction {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 0
         }
 
@@ -383,7 +391,7 @@ function Test-ComplexFunction {
     )
 }
 '@
-            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings
             $violations.Count | Should -Be 2  # 'byname' and 'byid' case mismatches
             $violations | ForEach-Object { $_.Severity | Should -Be 'Warning' }
         }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,14 @@`
`3`	`3`
`4`	`4`	`BeforeAll {`
`5`	`5`	`$ruleName = 'PSUseConsistentParameterSetName'`
	`6`	`+`
	`7`	`+ $ruleSettings = @{`
	`8`	`+ Enable = $true`
	`9`	`+ }`
	`10`	`+ $settings = @{`
	`11`	`+ IncludeRules = @($ruleName)`
	`12`	`+ Rules = @{ $ruleName = $ruleSettings }`
	`13`	`+ }`
`6`	`14`	`}`
`7`	`15`
`8`	`16`	`Describe "UseConsistentParameterSetName" {`
`@@ -20,7 +28,7 @@ function Test-Function {`
`20`	`28`	`)`
`21`	`29`	`}`
`22`	`30`	`'@`
`23`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`31`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`24`	`32`	`$violations.Count \| Should -Be 1`
`25`	`33`	`$violations[0].Severity \| Should -Be 'Warning'`
`26`	`34`	`$violations[0].Message \| Should -Match "DefaultParameterSetName 'SetOne' does not match the case of ParameterSetName 'setone'"`
`@@ -39,7 +47,7 @@ function Test-Function {`
`39`	`47`	`)`
`40`	`48`	`}`
`41`	`49`	`'@`
`42`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`50`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`43`	`51`	`$violations.Count \| Should -Be 2`
`44`	`52`	`$violations \| ForEach-Object { $_.Severity \| Should -Be 'Warning' }`
`45`	`53`	`}`
`@@ -62,7 +70,7 @@ function Test-Function {`
`62`	`70`	`)`
`63`	`71`	`}`
`64`	`72`	`'@`
`65`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`73`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`66`	`74`	`$violations.Count \| Should -Be 1`
`67`	`75`	`$violations[0].Severity \| Should -Be 'Warning'`
`68`	`76`	`$violations[0].Message \| Should -Match "ParameterSetName 'setone' does not match the case of 'SetOne'"`
`@@ -83,7 +91,7 @@ function Test-Function {`
`83`	`91`	`)`
`84`	`92`	`}`
`85`	`93`	`'@`
`86`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`94`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`87`	`95`	`$violations.Count \| Should -Be 2 # Two mismatches with the first occurrence`
`88`	`96`	`$violations \| ForEach-Object { $_.Severity \| Should -Be 'Warning' }`
`89`	`97`	`}`
`@@ -103,7 +111,7 @@ function Test-Function {`
`103`	`111`	`)`
`104`	`112`	`}`
`105`	`113`	`'@`
`106`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`114`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`107`	`115`	`$violations.Count \| Should -Be 1`
`108`	`116`	`$violations[0].Severity \| Should -Be 'Warning'`
`109`	`117`	`$violations[0].Message \| Should -Match "uses parameter sets but does not specify a DefaultParameterSetName"`
`@@ -121,7 +129,7 @@ function Test-Function {`
`121`	`129`	`)`
`122`	`130`	`}`
`123`	`131`	`'@`
`124`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`132`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`125`	`133`	`$violations.Count \| Should -Be 2`
`126`	`134`	`$violations \| ForEach-Object { $_.Message \| Should -Be "Parameter 'Parameter1' is declared in parameter-set 'SetOne' multiple times." }`
`127`	`135`	`}`
`@@ -136,7 +144,7 @@ function Test-Function {`
`136`	`144`	`)`
`137`	`145`	`}`
`138`	`146`	`'@`
`139`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`147`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`140`	`148`	`$violations.Count \| Should -Be 2`
`141`	`149`	`$violations \| ForEach-Object { $_.Message \| Should -Be "Parameter 'Parameter1' is declared in parameter-set '__AllParameterSets' multiple times." }`
`142`	`150`	`}`
`@@ -151,7 +159,7 @@ function Test-Function {`
`151`	`159`	`)`
`152`	`160`	`}`
`153`	`161`	`'@`
`154`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`162`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`155`	`163`	`$violations.Count \| Should -Be 2`
`156`	`164`	`$violations \| ForEach-Object { $_.Message \| Should -Be "Parameter 'Parameter1' is declared in parameter-set '__AllParameterSets' multiple times." }`
`157`	`165`	`}`
`@@ -169,7 +177,7 @@ function Test-Function {`
`169`	`177`	`)`
`170`	`178`	`}`
`171`	`179`	`'@`
`172`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`180`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`173`	`181`	`$violations.Count \| Should -Be 1`
`174`	`182`	`$violations[0].Message \| Should -Match "should not contain new lines"`
`175`	`183`	`}`
`@@ -183,7 +191,7 @@ function Test-Function {`
`183`	`191`	`)`
`184`	`192`	`}`
`185`	`193`	`'@`
`186`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`194`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`187`	`195`	`$violations.Count \| Should -Be 1`
`188`	`196`	`$violations[0].Message \| Should -Match "should not contain new lines"`
`189`	`197`	`}`
`@@ -197,7 +205,7 @@ function Test-Function {`
`197`	`205`	`)`
`198`	`206`	`}`
`199`	`207`	`'@`
`200`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`208`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`201`	`209`	`$violations.Count \| Should -Be 1`
`202`	`210`	`}`
`203`	`211`
`@@ -210,7 +218,7 @@ function Test-Function {`
`210`	`218`	`)`
`211`	`219`	`}`
`212`	`220`	`'@`
`213`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`221`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`214`	`222`	`$violations.Count \| Should -Be 1`
`215`	`223`	`$violations[0].Message \| Should -Match "should not contain new lines"`
`216`	`224`	`}`
`@@ -224,7 +232,7 @@ function Test-Function {`
`224`	`232`	`)`
`225`	`233`	`}`
`226`	`234`	`'@`
`227`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`235`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`228`	`236`	`$violations.Count \| Should -Be 1`
`229`	`237`	`$violations[0].Message \| Should -Match "should not contain new lines"`
`230`	`238`	`}`
`@@ -237,7 +245,7 @@ function Test-Function {`
`237`	`245`	`param([string]$Parameter1)`
`238`	`246`	`}`
`239`	`247`	`'@`
`240`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`248`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`241`	`249`	`$violations.Count \| Should -Be 1`
`242`	`250`	`}`
`243`	`251`
`@@ -253,7 +261,7 @@ function Test-Function {`
`253`	`261`	`)`
`254`	`262`	`}`
`255`	`263`	`'@`
`256`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`264`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`257`	`265`	`$violations.Count \| Should -Be 0`
`258`	`266`	`}`
`259`	`267`
`@@ -267,7 +275,7 @@ function Test-Function {`
`267`	`275`	`)`
`268`	`276`	`}`
`269`	`277`	`'@`
`270`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`278`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`271`	`279`	`$violations.Count \| Should -Be 0`
`272`	`280`	`}`
`273`	`281`
`@@ -284,7 +292,7 @@ function Test-Function {`
`284`	`292`	`)`
`285`	`293`	`}`
`286`	`294`	`'@`
`287`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`295`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`288`	`296`	`$violations.Count \| Should -Be 0`
`289`	`297`	`}`
`290`	`298`
`@@ -304,7 +312,7 @@ function Test-Function {`
`304`	`312`	`)`
`305`	`313`	`}`
`306`	`314`	`'@`
`307`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`315`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`308`	`316`	`$violations.Count \| Should -Be 0`
`309`	`317`	`}`
`310`	`318`
`@@ -323,7 +331,7 @@ function Test-Function {`
`323`	`331`	`)`
`324`	`332`	`}`
`325`	`333`	`'@`
`326`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`334`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`327`	`335`	`$violations.Count \| Should -Be 0`
`328`	`336`	`}`
`329`	`337`
`@@ -339,7 +347,7 @@ function Test-Function {`
`339`	`347`	`)`
`340`	`348`	`}`
`341`	`349`	`'@`
`342`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`350`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`343`	`351`	`$violations.Count \| Should -Be 0`
`344`	`352`	`}`
`345`	`353`	`}`
`@@ -362,7 +370,7 @@ function Test-ComplexFunction {`
`362`	`370`	`)`
`363`	`371`	`}`
`364`	`372`	`'@`
`365`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`373`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`366`	`374`	`$violations.Count \| Should -Be 0`
`367`	`375`	`}`
`368`	`376`
`@@ -383,7 +391,7 @@ function Test-ComplexFunction {`
`383`	`391`	`)`
`384`	`392`	`}`
`385`	`393`	`'@`
`386`		`- $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)`
	`394`	`+ $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings`
`387`	`395`	`$violations.Count \| Should -Be 2 # 'byname' and 'byid' case mismatches`
`388`	`396`	`$violations \| ForEach-Object { $_.Severity \| Should -Be 'Warning' }`
`389`	`397`	`}`