Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues when accepting an invite #24971

Open
corywatilo opened this issue Sep 13, 2024 · 4 comments
Open

UI issues when accepting an invite #24971

corywatilo opened this issue Sep 13, 2024 · 4 comments

Comments

@corywatilo
Copy link
Contributor

I was watching a user accept an invite and witnessed a couple oddities that would be worth fixing. I didn't try to repro them again, so not sure if they were flukes, but worth checking the next time someone is working in here.

  1. Clicking into the empty password field didn't automatically pop up the suggest password dropdown. I was able to right-click where I found the option to "Suggest password", but it was odd that it didn't open when clicking into the input once like most other websites.
  2. When clicking the yellow submit button to create the account (after entering a password), a red dot (I think it was a dot?) appeared below the input, making it look like there was an issue with password validation (but with no text displayed). But after the form processed, it correctly went to the email verification screen. So, just looks like something is up with the password validation on the UI side.
@prankurpandeyy
Copy link

I would like to work on this issue

@ctrl-alter-ego
Copy link
Contributor

ctrl-alter-ego commented Sep 16, 2024

Hi @corywatilo, I can replicate the second part (a red exclamation mark appears under password field, even if creating account is successful) but I don't see a suggest password feature. Does PostHog have one built-in and I'm just not seeing it, or might this have been a browser plugin you have, like 1password, for example? Apologies if I'm missing something obvious.

EDIT: To further aid debugging, the red exclamation under password will also appear if omitting a name, (it's not related to this, however, as this has its own red exclamation icon and the one under the password field can be seen briefly before the page submits successfully). It's just a good way to get it to show up indefinitely, if helpful.

@abhi12299
Copy link
Contributor

@ctrl-alter-ego it seems like a browser plugin. I've not seen any other website show the pop-up natively either.

Also, the form error handling is fixed #24982 - it handles all the fields properly.

@ctrl-alter-ego
Copy link
Contributor

Aha, excellent. Thanks for the update @abhi12299.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants