Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep bottom positioned popups fixed to the bottom even if the browser's bottom toolbar disappears #977

Open
marklchaves opened this issue Oct 26, 2021 · 1 comment
Milestone

Comments

@marklchaves
Copy link
Contributor

Describe the feature request

Allow popups that are fixed to the bottom to remain fixed to the bottom of the viewport on mobile even when the browser's bottom toolbar disappears (when scrolling down).

Temporary fix

@media (max-width: 640px) {
    #popmake-15.pum-container { /* Change to your popup's ID */
      bottom: 0 !important;
      margin-bottom: 0 !important;
      max-height: 500px; /* Change to your height */
      top: auto !important;
    }
  }

Use case

See the OP on .org.

https://wordpress.org/support/topic/scrolling-on-mobile-6/

Example screenshots (if any)

Screencast: https://share.wppopupmaker.com/mXuPBLZq

@danieliser danieliser added this to the v1.17 milestone Nov 22, 2021
@danieliser
Copy link
Member

@marklchaves Have you tested whether it works?

I assume the goal is to override the built in positioning, which always positions from the top of the screen?

Couple of thoughts:

  1. Does it still work without the popup being a fixed height?
  2. Could we somehow in JavaScript detect an event related to that browser bar hiding, and trigger a reposition of the popup, thus negating needs for hackish fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants