clippy

Author: enpsi

gkr/src/prover/gkr_square.rs

@@ -10,6 +10,7 @@ use polynomials::MultiLinearPoly;
 use sumcheck::{sumcheck_prove_gkr_square_layer, ProverScratchPad};
 use transcript::Transcript;
 
+#[allow(clippy::type_complexity)]
 pub fn gkr_square_prove<C: GKRFieldConfig, T: Transcript<C::ChallengeField>>(
     circuit: &Circuit<C>,
     sp: &mut ProverScratchPad<C>,

gkr/src/tests/gkr_correctness.rs

@@ -407,7 +407,7 @@ fn do_prove_verify<Cfg: GKRConfig>(config: Config<Cfg>, circuit: &mut Circuit<Cf
 
     // Prove
     let mut prover = Prover::new(&config);
-    prover.prepare_mem(&circuit);
+    prover.prepare_mem(circuit);
     let (claimed_v, proof) = prover.prove(circuit, &pcs_params, &pcs_proving_key, &mut pcs_scratch);
 
     // Verify if root process

sumcheck/src/prover_helper/sumcheck_gkr_square.rs

@@ -119,7 +119,7 @@ impl<'a, C: GKRFieldConfig, const D: usize> SumcheckGkrSquareHelper<'a, C, D> {
         let mut evals = self.mpi_helper.gkr2_poly_eval_at::<C, D>(
             var_idx,
             &self.sp.eq_evals_at_r_mpi0,
-            &mut self.sp.mpi_var_v_evals,
+            &self.sp.mpi_var_v_evals,
             self.sp.hg_evals_1[0],
             self.sp.hg_evals_5[0],
         );

sumcheck/src/sumcheck.rs

@@ -95,6 +95,7 @@ pub fn sumcheck_prove_gkr_layer<C: GKRFieldConfig, T: Transcript<C::ChallengeFie
 
 // FIXME
 #[allow(clippy::needless_range_loop)] // todo: remove
+#[allow(clippy::type_complexity)]
 pub fn sumcheck_prove_gkr_square_layer<C: GKRFieldConfig, T: Transcript<C::ChallengeField>>(
     layer: &CircuitLayer<C>,
     rz0: &[C::ChallengeField],

sumcheck/src/verifier_helper.rs

@@ -262,6 +262,7 @@ impl GKRVerifierHelper {
     }
 
     #[inline(always)]
+    #[allow(clippy::needless_range_loop)]
     fn lag_eval<C: GKRFieldConfig>(
         vals: &[C::ChallengeField],
         x: C::ChallengeField,