fix: Make GfxPluginNativeRender function properly with new config.
#1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y ConsoleApplication. Remove extraneous comments in ConsoleApplication.cpp.
…bsolute to the build path.
…tead of copying the parameter value each time. Also add documentation to functions that have been altered.
…omments to clarify what is going on.
… body of read_config_json_as_json_from_path, and added a check for the return value of fclose within that function.
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/ConfigPaths.props
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductConfig.hpp
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
...NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductionEnvironments.hpp
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Serializable.hpp
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Serializable.hpp
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Serializable.hpp
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/SteamConfig.h
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Version.hpp
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/config_legacy.h
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/config_legacy.h
Outdated
Show resolved
Hide resolved
paulhazen
commented
Nov 30, 2024
paulhazen
commented
Nov 30, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/config_legacy.cpp
Outdated
Show resolved
Hide resolved
andrew-hirata-playeveryware
suggested changes
Dec 17, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/PlatformConfig.hpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductConfig.hpp
Show resolved
Hide resolved
...NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductionEnvironments.hpp
Show resolved
Hide resolved
...NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductionEnvironments.hpp
Outdated
Show resolved
Hide resolved
...NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/ProductionEnvironments.hpp
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Serializable.hpp
Outdated
Show resolved
Hide resolved
...ode/DynamicLibraryLoaderHelper/DynamicLibraryLoaderHelper/DynamicLibraryLoaderHelper.vcxproj
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/SteamConfig.hpp
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/Version.hpp
Outdated
Show resolved
Hide resolved
andrew-hirata-playeveryware
suggested changes
Dec 18, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
| @@ -101,7 +101,7 @@ namespace pew::eos::string_helpers | |||
| } | |||
|
|
|||
| // wide_str must be null terminated if wide_str_len is passed | |||
| bool copy_to_utf8_str_from_wide_str(char* RESTRICT utf8_str, size_t utf8_str_len, const wchar_t* RESTRICT wide_str, int wide_str_len) | |||
There was a problem hiding this comment.
That is true, but I don't think the change is needed to get the gfx code to read the config file.
…Options functions to return struct values, and enclose them in a _DEBUG compile conditional.
…ify UnityPluginLoad function so that it does not display a dialog when building the ConsoleApplication project.
…d and is_sandbox_defined functions.
paulhazen
force-pushed
the
fix/native-use-new-config
branch
from
84f2ffb to
70b4fc6
Compare
…ring proper initialization of the eos sdk.
andrew-hirata-playeveryware
suggested changes
Dec 20, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/PlatformConfig.hpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/include/Config/WindowsConfig.hpp
Outdated
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Show resolved
Hide resolved
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Show resolved
Hide resolved
…static. Include functionality to make sure that it is properly set and can be retrieved from a static context.
andrew-hirata-playeveryware
suggested changes
Dec 21, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
andrew-hirata-playeveryware
suggested changes
Dec 21, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
andrew-hirata-playeveryware
suggested changes
Dec 21, 2024
lib/NativeCode/DynamicLibraryLoaderHelper/NativeRender/src/eos_helpers.cpp
Outdated
Show resolved
Hide resolved
andrew-hirata-playeveryware
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the native component of the plugin to function properly with the new config files.
It has been tested and is functioning properly, but this PR does not include the unit tests that prove that.
I recommend that because
developmentis in a broken state because of the native code component when in standalone on Windows, we get these changes in and supplement them with the unit testing.One area that still needs to be tested is the steam integration component. I have been limited in my ability to test that due to a lack of understanding all the mechanics of that process.
#EOS-2231