resolving comments

PiyushDub · Oct 25, 2024 · 1c780f4 · 1c780f4
1 parent 0cc54c0
commit 1c780f4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/Modules/Microsoft365DSC/Examples/Resources/AADAccessReviewPolicy/2-Update.ps1 b/Modules/Microsoft365DSC/Examples/Resources/AADAccessReviewPolicy/2-Update.ps1
@@ -23,11 +23,11 @@ Configuration Example
     {
         AADAccessReviewPolicy "AADAccessReviewPolicy"
         {
-            ApplicationId                 = $ConfigurationData.NonNodeData.ApplicationId;
-            CertificateThumbprint         = $ConfigurationData.NonNodeData.CertificateThumbprint;
             IsGroupOwnerManagementEnabled = $False;
             IsSingleInstance              = "Yes";
-            TenantId                      = $OrganizationName;
+            ApplicationId                 = $ApplicationId
+            TenantId                      = $TenantId
+            CertificateThumbprint         = $CertificateThumbprint
         }
 
     }

diff --git a/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/1-Create.ps1 b/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/1-Create.ps1
@@ -23,8 +23,6 @@ Configuration Example
     {
         AADHomeRealmDiscoveryPolicy "AADHomeRealmDiscoveryPolicy-displayName-value"
         {
-            ApplicationId         = $ConfigurationData.NonNodeData.ApplicationId;
-            CertificateThumbprint = $ConfigurationData.NonNodeData.CertificateThumbprint;
             Definition            = @(
                 MSFT_AADHomeRealDiscoveryPolicyDefinition {
                     PreferredDomain       = 'federated.example.edu'
@@ -37,7 +35,9 @@ Configuration Example
             DisplayName           = "displayName-value";
             Ensure                = "Present";
             IsOrganizationDefault = $False;
-            TenantId              = $OrganizationName;
+            ApplicationId         = $ApplicationId
+            TenantId              = $TenantId
+            CertificateThumbprint = $CertificateThumbprint
         }
     }
 }
diff --git a/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/2-Update.ps1 b/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/2-Update.ps1
@@ -23,8 +23,6 @@ Configuration Example
     {
         AADHomeRealmDiscoveryPolicy "AADHomeRealmDiscoveryPolicy-displayName-value"
         {
-            ApplicationId         = $ConfigurationData.NonNodeData.ApplicationId;
-            CertificateThumbprint = $ConfigurationData.NonNodeData.CertificateThumbprint;
             Definition            = @(
                 MSFT_AADHomeRealDiscoveryPolicyDefinition {
                     PreferredDomain       = 'federated.example.edu'
@@ -37,7 +35,9 @@ Configuration Example
             DisplayName           = "displayName-value";
             Ensure                = "Present";
             IsOrganizationDefault = $False;
-            TenantId              = $OrganizationName;
+            ApplicationId         = $ApplicationId
+            TenantId              = $TenantId
+            CertificateThumbprint = $CertificateThumbprint
         }
     }
 }
diff --git a/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/3-Remove.ps1 b/Modules/Microsoft365DSC/Examples/Resources/AADHomeRealmDiscoveryPolicy/3-Remove.ps1
@@ -23,8 +23,6 @@ Configuration Example
     {
         AADHomeRealmDiscoveryPolicy "AADHomeRealmDiscoveryPolicy-displayName-value"
         {
-            ApplicationId         = $ConfigurationData.NonNodeData.ApplicationId;
-            CertificateThumbprint = $ConfigurationData.NonNodeData.CertificateThumbprint;
             Definition            = @(
                 MSFT_AADHomeRealDiscoveryPolicyDefinition {
                     PreferredDomain       = 'federated.example.edu'
@@ -37,7 +35,9 @@ Configuration Example
             DisplayName           = "displayName-value";
             Ensure                = "Absent";
             IsOrganizationDefault = $False;
-            TenantId              = $OrganizationName;
+            ApplicationId         = $ApplicationId
+            TenantId              = $TenantId
+            CertificateThumbprint = $CertificateThumbprint
         }
     }
 }