Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade boost to 1.70.0 on macos #1369

Closed
meshula opened this issue Oct 23, 2020 · 1 comment
Closed

Upgrade boost to 1.70.0 on macos #1369

meshula opened this issue Oct 23, 2020 · 1 comment

Comments

@meshula
Copy link
Member

meshula commented Oct 23, 2020

Description of Issue

Under Xcode 12, b2, the build engine for boost 1.6x.x, no longer compiles due to clang now defaulting to the warning that a function has been implicitly declared, has been defaulted to be an error. A full description of the problem, by @rlei-weta is here: boostorg/build#664

The current code in the build script reads as follows:

if Linux() or MacOS():
    if Python3():
        BOOST_URL = "https://downloads.sourceforge.net/project/boost/boost/1.70.0/boost_1_70_0.tar.gz"
    else:
        BOOST_URL = "https://downloads.sourceforge.net/project/boost/boost/1.61.0/boost_1_61_0.tar.gz"
    BOOST_VERSION_FILE = "include/boost/version.hpp"

If on macOS we only ever get 1.70.0 then an Xcode 12 build will succeed for Python2 as well. This solution deviates from the vfx2018 platform, but that seems unavoidable.

A proposed fix would be:

if MacOS():
    BOOST_URL = "https://downloads.sourceforge.net/project/boost/boost/1.70.0/boost_1_70_0.tar.gz"
    BOOST_VERSION_FILE = "include/boost/version.hpp"
elseif Linux():
    if Python3():
        BOOST_URL = "https://downloads.sourceforge.net/project/boost/boost/1.70.0/boost_1_70_0.tar.gz"
    else:
        BOOST_URL = "https://downloads.sourceforge.net/project/boost/boost/1.61.0/boost_1_61_0.tar.gz"
    BOOST_VERSION_FILE = "include/boost/version.hpp"

Steps to Reproduce

  1. Try to build usd with the stock build script, for Python2, under Xcode 12

System Information (OS, Hardware)

Xcode 12

@jilliene
Copy link

Filed as internal issue #USD-6447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants