Feature Request: Optional target_url

[rfpludwick]

I would love to be able to optionally set the target_url when setting the GH status. One of the Concourse CI systems I run is entirely private, but it does run pipelines for a public repository on GitHub. I'd like to be able to report build status, but without the URL as that is private information. Could define the optional target URL either in the resource configuration or on the put.

    on_success:
      put: gh-status
      inputs: [the-repo]
      params: {state: success, target_url: false}

---

- name: gh-status
  type: cogito
  check_every: never
  source:
    owner: ((github-owner))
    repo: ((your-repo-name))
    access_token: ((github-PAT))
    target_url: false

[marco-m-pix4d]

Ah, I understand the reasoning. Makes sense. I appreciate that you proposed a possible and backwards compatible configuration for this.

My first reaction is wondering if there is a way to make the intent more explicit. For example: omit_target_url (bool). In any case, this is a nitpick.

[rfpludwick]

@marco-m-pix4d Yeah, something like omit_target_url is probably better! I like that.

[marco-m-pix4d]

@rfpludwick I discussed with the team and we think it is a reasonable request. Would you be interested in proposing a PR?

[rfpludwick]

@marco-m-pix4d I can give it a try. My Go experience isn't super deep, but I think I can muddle my way through to an acceptable PR eventually.

[marco-m-pix4d]

I had some time and went ahead with #160.

[rfpludwick]

Ah fantastic! Thanks @marco-m-pix4d!