New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the root private key should not be used for sealing Biscuit tokens #20

Open

Geal opened this issue Oct 9, 2020 · 1 comment

Geal commented Oct 9, 2020

I'm not sure if it will result in a big vulnerability, but it would be better to have a dedicated secret key for this: https://github.com/PierreZ/record-store/blob/master/record-store/src/main/java/fr/pierrezemb/recordstore/auth/BiscuitManager.java#L80

Owner

PierreZ commented Oct 12, 2020 •

edited

Loading

Thanks @Geal for the issue!

The BiscuitManager trully need some improvements indeed, I'll add another private key for this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment