Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add --no-align / what algorithm is used for alignment? #28

Open
tokiAi opened this issue Sep 3, 2022 · 5 comments
Open

Request: add --no-align / what algorithm is used for alignment? #28

tokiAi opened this issue Sep 3, 2022 · 5 comments

Comments

@tokiAi
Copy link

tokiAi commented Sep 3, 2022

Hi,
would it be possible to add a way to use no alignment to use other alignment algorithms. e.g. as parameter --no-align

Also, could you please tell me which alignment algorithm you use. And possibly add this information to the documentation for others.

@tokiAi tokiAi changed the title add --no-align / what algorithm is used for alignment? Request: add --no-align / what algorithm is used for alignment? Sep 3, 2022
@PetteriAimonen
Copy link
Owner

As mentioned in https://github.com/PetteriAimonen/focus-stack#algorithms-used and https://github.com/PetteriAimonen/focus-stack/blob/master/docs/Algorithms.md, the algorithm used is OpenCV findTransformECC.

So far I have not seen cases where the alignment wouldn't work fairly well. If you have such test cases, please post them somewhere.

@tokiAi
Copy link
Author

tokiAi commented Sep 3, 2022

Ah sorry, I must have overlooked it.

So the parameter would be to test other alignment algorithms. I would like to test whether these bring better results.

@PetteriAimonen
Copy link
Owner

Any such testing is better done by editing the source code. If some algorithm consistently produces better results, only then is there point considering replacement or option.

@mviereck
Copy link

mviereck commented Sep 3, 2022

An option --no-align is useful if one has already aligned images and want to compare the stacking results of different stacking tools.
It is also useful if one provides a frontend where aligning and stacking are done in different steps and the frontend provides different alignment or stacking tools by choice. (This will be the case in my project once I continue to develop it.)

@PetteriAimonen
Copy link
Owner

Oh well. Not something I'm interested in adding, but I don't oppose a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants