Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop / NoCrop / Alignment question #20

Open
LGimmick opened this issue May 18, 2022 · 5 comments
Open

Crop / NoCrop / Alignment question #20

LGimmick opened this issue May 18, 2022 · 5 comments

Comments

@LGimmick
Copy link

Hi,

I have tried your program and I think the result is very good and it's realy fast.
But I noticed something concerning the crop-function:

The crop only works if the image content moves to the right - so the offset is oriented left. Otherwise the mirrored image content on the left side stays in the final image. [Global-Alignment and changed reference image does fix this, not sure about vertical movement].
And I have a few image-sets without any content-movement. The input-images have a resolution of 1600x1200 px. No matter what parameters I use, all aligned images (even the first one with reference = 0 and global-align) are created with 1664x1216 px and the result image contains the mirrored content on all edges, too.
I guess it's kind of the same effect and problem seems to happen somewhere in the calculation of the area with full data.

@PetteriAimonen
Copy link
Owner

Hmm, I also received other report of similar problem.

Can you send me a test image set that reproduces the problem? If it is too large for upload here, you can mail me at petteri.aimonen (at) devembedded.com

@LGimmick
Copy link
Author

I've sent you some images :).

@PetteriAimonen
Copy link
Owner

@LGimmick Thanks for the logs. The key line was "Valid area not defined for aligned_Object3.bmp, using default.".

The OpenCL-accelerated code was not setting the valid area, so the bug only appeared when OpenCL was available. Fixed in commit 881e6b5.

There is new build for testing here:
https://github.com/PetteriAimonen/focus-stack/releases/tag/latest

@pjrose
Copy link

pjrose commented May 18, 2022

New version works for me, too.

@LGimmick
Copy link
Author

Thank you!
Works perfectly fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants