Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFolder does not return fully populated ArchiveRecords #73

Open
slifty opened this issue Feb 1, 2023 · 0 comments
Open

getFolder does not return fully populated ArchiveRecords #73

slifty opened this issue Feb 1, 2023 · 0 comments

Comments

@slifty
Copy link
Contributor

slifty commented Feb 1, 2023

This is, to some extent, a known behavior however it is not ideal.

First: it would be better if the ArchiveRecord children returned in a getFolder result contained Files. This would prevent our clients from having to make one-new-API-call per ArchiveRecord in contexts where they want the file associated with a given ArchiveRecord.

Second: if we DO keep the current behavior, it needs to be clearly communicated via types that Folder.archiveRecords will never have populated files. Otherwise you get people writing code expecting files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant