Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent method names #3

Open
jtpalmer opened this issue Aug 13, 2012 · 2 comments
Open

Inconsistent method names #3

jtpalmer opened this issue Aug 13, 2012 · 2 comments

Comments

@jtpalmer
Copy link
Member

SDLx::Widget::Menu has method event_hook

SDLx::Widget::Textbox has method event_handler

These methods both have the same use case. We should probably pick one of name and stick with that.

@jtpalmer
Copy link
Member Author

After another look, it might make sense to make event_hander a private method for the textbox.

@FROGGS
Copy link
Member

FROGGS commented Aug 13, 2012

You are right, that Textbox::event_handler should be private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants