Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] innerSeams against other blocks? #236

Open
muzikbike opened this issue Apr 1, 2023 · 1 comment
Open

[Request] innerSeams against other blocks? #236

muzikbike opened this issue Apr 1, 2023 · 1 comment
Labels

Comments

@muzikbike
Copy link

Today I've been experimenting with MCPatcher's CTM functionality to see if I could backport the WIP resource pack I'll never complete back to then, and to understand the differences between historical and modern implementations of connected textures (such as things mentioned in #231). There's one thing I've noticed about innerSeams back then: they would apply against any full blocks which obstructed a face, rather than only instances of the same block.

Here's a screenshot using the experimental pack in 1.7.10. This is how it looks with innerSeams disabled:
2023-04-01_15 33 05
2023-04-01_15 33 06

And with it enabled:
2023-04-01_15 33 26
2023-04-01_15 33 27

With Continuity in 1.19.4, even if innerSeams is enabled, blocks of other types will not cause this effect to happen.
2023-04-01_15 47 41

The same is true in OptiFine (so I may also open a request there):
2023-04-01_15 41 54

Of course, just changing the current innerSeams behaviour to this one from 1.7.10 would be undesirable since many resource packs are built under the assumption of the current behaviour. However, I think I personally prefer the MCPatcher handling of cases like these. Would an option of some sort be possible that could allow for changes between these two different types of innerSeams behaviour (current "only against same block type" behaviour would be default, and there'd be a second "against any block that culls the face of this block" option), assuming it doesn't exist already? I'm not sure if this would fit entirely in the scope of the mod if it's only meant to be compatible with OptiFine's CTM implementation, but it's something I'd very much like to see if possible.

I can provide the resource packs used in each case if desired for testing purposes.

@PepperCode1
Copy link
Owner

This is simple enough to do. I will have to confirm exactly how it works in MCPatcher by looking at its code. A new property can be added to switch between the modes, with Optifine's mode being the default. This plan is not final, however; after investigation I may make changes to it.

I should clarify that "only against same block type" is not correct. innerSeams in Optifine uses the connection predicate connect; if the original block would connect to the obstructing block, the connection does not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants