Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth-hot-wallet assumes transaction is guaranteed to be executed after sending #41

Open
1 task done
darcher-framework opened this issue Dec 25, 2020 · 0 comments
Open
1 task done

Comments

@darcher-framework
Copy link

Eth-Hot-Wallet

Issue Type

  • Bug

Description

The DApp always assumes a transfer transaction sent to Ethereum network is guaranteed to be executed.
But a transaction in the pending pool can be dropped either by miners or users. But Eth-hot-wallet shows transaction success after the transaction is sent but not executed.
image

Steps to reproduce

  1. Send a transaction using eth-hot-wallet.
  2. Before the transaction is executed/mined, use metamask send another transaction with same nonce but higher gasPrice.
  3. The transaction sent by eth-hot-wallet is dropped but eth-hot-wallet still shows the transaction succeeds.

Versions

  • ETH-Hot-Wallet (see package.json): v0.6.0
  • Node/NPM: v10.23.0
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant