Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

yeet gson #75

Open
sylv256 opened this issue Oct 21, 2020 · 4 comments
Open

yeet gson #75

sylv256 opened this issue Oct 21, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@sylv256
Copy link

sylv256 commented Oct 21, 2020

gson bad
jsoniter go brrrr

@TheGlitch76 TheGlitch76 added the enhancement New feature or request label Oct 21, 2020
@ramidzkh
Copy link
Member

ramidzkh commented Nov 4, 2020

What are the benefits? Patching is a one time relatively-fast process, and GSON is known to be reliable

@kitlith
Copy link

kitlith commented Nov 4, 2020

for some reason i was interpreting this as "replace gson w/ jsoniter in minecraft" which, in retrospect, makes no sense.

jsoniter's primary benefit over gson appears to be speed, so, I guess it depends on how much time is spent dealing with json in patcher. I'd guess the majority of the time is spent visiting stuff for patching though? (i don't know)

@sylv256
Copy link
Author

sylv256 commented Nov 4, 2020

fabric did it, so why not us?

@ramidzkh
Copy link
Member

ramidzkh commented Nov 5, 2020

Because fabric-loader has a good reason to - to not mess with Minecraft's dependencies. Copying someone else for no good reason is usually a bad idea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants