Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sdlatomic.inc according to code style guidelines #58

Open
Free-Pascal-meets-SDL-Website opened this issue Jun 17, 2022 · 0 comments
Open

Update sdlatomic.inc according to code style guidelines #58

Free-Pascal-meets-SDL-Website opened this issue Jun 17, 2022 · 0 comments
Labels
good first issue Good for newcomers to do Some update necessary, critical or not

Comments

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator

To be in accordance with the code style guidelines, which states to stay as close as possible with the C code, I would suggest the following updates for sdlatomic.inc:

Line 42: Rename TSDL_Atomic into TSDL_atomic_t and lower-case Value + also adapt all parameter lists consequently
Line 49 + 87: Rename param. list (oldValue into oldval, ...)
Many param lists: Rename atomic by a and value by v.
@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website added the to do Some update necessary, critical or not label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers to do Some update necessary, critical or not
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Free-Pascal-meets-SDL-Website