Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility #27

Open
tjibbed opened this issue Mar 7, 2024 · 1 comment
Open

Backward compatibility #27

tjibbed opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tjibbed
Copy link
Collaborator

tjibbed commented Mar 7, 2024

As part of a dashboard development I noticed the following:

RDS files created using older versions of the package don't allow for the node and ring colouring in the circular network plot, even when using the newer version of the package. This because the plotting function is stored in the HospiNet object, and the older plotting function doesn't recognise the extra arguments.

To solve this, I propose creating a version of the $new() function that just takes the entire object, copies the network information into the current HospiNet object, that does contain the current plotting function.

As an additions, I'd like to propose adding an attribute to the object that contains the version number, so any application using the package can check if the input object was created using the most recent version.

@tjibbed tjibbed added the enhancement New feature or request label Mar 7, 2024
@tjibbed
Copy link
Collaborator Author

tjibbed commented Mar 7, 2024

Note that my current workaround suffers from a bug reported in issue #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant