Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping-IO adapter #9

Open
NebelNidas opened this issue Oct 10, 2023 · 3 comments · May be fixed by #14
Open

Mapping-IO adapter #9

NebelNidas opened this issue Oct 10, 2023 · 3 comments · May be fixed by #14
Labels
enhancement New feature or request

Comments

@NebelNidas
Copy link

NebelNidas commented Oct 10, 2023

An adapter to convert from/to Fabric's Mapping-IO library would be nice. I'd be willing to code this myself (most of the recent developments on the lib were contributed by me), but I first need to know if that would be accepted.

Edit: It should be noted that we're currently in the process of moving Enigma itself to said library, so this feature would allow for more direct interop without homegrown readers/writers in Compass.

@sciwhiz12 sciwhiz12 added the enhancement New feature or request label Oct 10, 2023
@sciwhiz12
Copy link
Member

That sounds acceptable, yeah. Such an adapter would likely live as a io-* subproject, in a similar fashion to io-proguard, I think.

@zml2008
Copy link

zml2008 commented Oct 10, 2023

ah yes, io-mapping-io :p

@Lanse505
Copy link
Member

ah yes, io-mapping-io :p

Time to make an adapter for io-mapping-io so we can achieve peak recursion memes

@NebelNidas NebelNidas changed the title Add Mapping-IO adapter Mapping-IO adapter Dec 6, 2023
@NebelNidas NebelNidas linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants