Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK to make a PR to override parallels tools location? #421

Open
tolmasky opened this issue May 8, 2022 · 1 comment
Open

OK to make a PR to override parallels tools location? #421

tolmasky opened this issue May 8, 2022 · 1 comment

Comments

@tolmasky
Copy link

tolmasky commented May 8, 2022

Without going into a ton of detail, in our setup the automatic parallels tools discovery that vagrant parallels uses through mdfind can't work. We currently have a private fork of vagrant-parallels that replaces this line in installs_parallels_tools.rb with the specific location on our system. I'd love to not have to keep the private fork, and instead add a generic way of doing this. Either by providing a config path option, or possibly even a config callback (so that guest-os and arch can be passed in). If I were to do this, would that be an acceptable PR?

@legal90
Copy link
Collaborator

legal90 commented May 10, 2022

Hi @tolmasky ,
Yes, sure, please send a PR and I'll be happy to review it 👍
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants