Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country names not preserved from modded sources #1382

Open
Zemurin opened this issue Jan 17, 2022 · 3 comments
Open

Country names not preserved from modded sources #1382

Zemurin opened this issue Jan 17, 2022 · 3 comments
Labels
bug Something isn't working coding
Milestone

Comments

@Zemurin
Copy link
Member

Zemurin commented Jan 17, 2022

Vic2 locs have YUG country name "Yugoslavia-Hungary", but hoi4 conversion uses default hoi4 (or vanilla vic2?) "yugoslavia" instead. We maybe should load vic2 names instead.

ditto for _ADJ.

@Idhrendur Idhrendur added bug Something isn't working coding labels Jan 18, 2022
@Idhrendur Idhrendur added this to the 0.4 milestone Jan 18, 2022
@cetvrtak
Copy link
Collaborator

They get an override from Configurables\Vic2Localisations\Vic2Localisations.csv. I have no clue what's the purpose, though

@IohannesIohannium
Copy link
Contributor

They get an override from Configurables\Vic2Localisations\Vic2Localisations.csv. I have no clue what's the purpose, though

The override is not intended in-theory. It was meant to supply/integrate vanilla localizations for languages not in Vic2 (Russian, Polish, Portuguese)

@Idhrendur
Copy link
Member

Ah, that's more clear. I've created some new bugs for the steps we'd need to take to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coding
Projects
None yet
Development

No branches or pull requests

4 participants