Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culture tweaks for conversion to Fallen Eagle #1590

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Culture tweaks for conversion to Fallen Eagle #1590

merged 3 commits into from
Nov 4, 2023

Conversation

DEO211
Copy link
Contributor

@DEO211 DEO211 commented Nov 4, 2023

Culture changes that are primarily related to TFE conversions with two exceptions. Mostly based on "Tweaks for conversion to Fallen Eagle" issue. Changes are:

  • Punic, Old Egyptian, Slavic, and Hunnic convert to their TFE equivalents
  • Dnieper Baltic and Slavic cultures are mapped to closest equivalent Invictus Balto-Slavic culture
  • South Arabic and Himyarite are mapped to the Invictus South Levantine culture group
  • Callaecian, Cantabrian and Asturian celtiberian cultures are mapped individually as they have TFE equivalents
  • TFE Noric and Illyrian represent their respective culture groups
  • More germanic tag cultures along with fixing ones that would previously never work
  • Change Tyrrenic mapping so Rhaetian could spawn in rhaetia

The two non-TFE exceptions I mentioned were the Tyrrenic change and the two germanic tag cultures of Frisian and Angle. Other than that, these changes only affect games converted with TFE.

Before:
steamuserimages-a akamaihd
(This screenshot was taken before the irRegion fixes were put out so Aegyptian, Alemannic, Sephardi, and Avar would normally be Hellenic, Suebi, Hebrew, and either Sarmatian or Scythian)

After:
steamuserimages-a akamaihd

@IhateTrains IhateTrains linked an issue Nov 4, 2023 that may be closed by this pull request
1 task
Copy link
Member

@IhateTrains IhateTrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! All but the herulian mapping looks good, please look at my comment.

ImperatorToCK3/Data_Files/configurables/culture_map.txt Outdated Show resolved Hide resolved
@IhateTrains IhateTrains merged commit 054b069 into ParadoxGameConverters:master Nov 4, 2023
10 checks passed
@IhateTrains IhateTrains added the enhancement New feature or request label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants