Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic post-colonial names #113

Open
IohannesIohannium opened this issue Jul 1, 2022 · 1 comment
Open

Dynamic post-colonial names #113

IohannesIohannium opened this issue Jul 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@IohannesIohannium
Copy link
Contributor

IohannesIohannium commented Jul 1, 2022

Such a feature does not seem supported yet in-game, but we may override the locs of the hub names and of the state name.

A configurable would be used as such:
link = { state = STATE_NEW_YORK colonizer = french city = "Buffle" mine = "Ville-de-Binne" farm = "Syracuse-lès-Indiens" wood = "Albanie" port = "Nouvelle Éboraque" state_name = "Néo-Éboraquaise" }

In this case, if New York is held by a French cultured country, the hub names and the state name are thus overwritten.
The first matching rule would be applied. All fields except for state and homeland are optional. If such fields are missing, no output is produced.

The overriding would be output in /localization/[language]/colonial_map_names_l_[language].yml (for each language), with this syntax:
HUB_NAME_[State key]_[Field key]:2 "[String]"

As an example, HUB_NAME_STATE_NEW_YORK_CITY:2 "Buffle".
The state name, instead, is just the bare State key (STATE_NEW_YORK:2 "Néo-Éboraquaise")

It'd be best to eventually move to nested locs for this configurable, so that dynamic names are correctly translated.

The overwriting practices of this file should be used lightly, as they would override #112's outputs as well

@Zemurin
Copy link
Member

Zemurin commented Apr 26, 2023

Related to #112 - We can rename states as well as hubs, according to eu4's cultural dynamic locs (if any are applicable). However, eu4 states don't match Vic3 states, and cities don't necessarily match eu4 cities, making this entire issue very difficult.

Maybe it'd be best to wait until vic3 inherently implements this on their own.

@Zemurin Zemurin added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants