Move downloads from DownloadService to using Gradle Configurations #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenilla
force-pushed
the
configuration-downloads
branch
5 times, most recently
from
13eaac0 to
b9fa720
Compare
|
not really in a position to review this, @DenWav, you said you have ideas for this too, do you like this approach? |
jpenilla
force-pushed
the
configuration-downloads
branch
3 times, most recently
from
85e1f29 to
459b2d6
Compare
jpenilla
force-pushed
the
configuration-downloads
branch
from
459b2d6 to
ae3f7d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of hacky but seems to work pretty well
edit: needs changes to work with configuration cache