feat: expose list order in TabListEntry #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any kind of check preventing the action from being sent to <1.21.2 clients? Same for addEntry. |
This comment was marked as resolved.
This comment was marked as resolved.
|
You forgot to (conditionally) add the action somewhere here: |
|
Oh, yeah, thanks! |
electronicboy
approved these changes
Nov 9, 2024
RealBauHD
approved these changes
Nov 9, 2024
4drian3d
approved these changes
Nov 9, 2024
pull bot
pushed a commit
to WiIIiam278/Velocity
that referenced
this pull request
Nov 16, 2024
* feat: expose list order in TabListEntry * fix: address comment (from github) * fix: address another comment (from github)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the tab list ordering introduced in 1.21.2.
Fixes: #1450