Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource pack callbacks are not triggered #1369

Open
scrayos opened this issue Jul 4, 2024 · 0 comments
Open

Resource pack callbacks are not triggered #1369

scrayos opened this issue Jul 4, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@scrayos
Copy link
Contributor

scrayos commented Jul 4, 2024

Expected Behavior

I expect the callbacks to be triggered just like the PlayerResourcePackStatusEvent works. There should be invocations of the callback for any change.

Actual Behavior

The callback is not invoked at all.

Steps to Reproduce

  1. Send a valid resource pack like below
  2. Wait for it to load successfully
  3. See that there is no log message
e.getPlayer().sendResourcePacks(
                ResourcePackRequest.resourcePackRequest()
                        .packs(
                                ResourcePackInfo.resourcePackInfo()
                                        .id(UUID.randomUUID())
                                        .uri(URI.create("https://example.io/…"))
                                        .hash("54ff1a362a90915aa44a3b3a5a…")
                                        .build()
                        )
                        .replace(true)
                        .required(true)
                        .callback(ResourcePackCallback.onTerminal(
                                (uuid, audience) -> System.out.println("SUCCESSFULLY LOADED IT"),
                                (uuid, audience) -> System.out.println("FAILED TO LOAD IT")
                        ))
                        .build()
        );

Plugin List

Only the test plugin

Velocity Version

[23:27:39 INFO]: Velocity 3.3.0-SNAPSHOT (git-aa4e8780-b401)
[23:27:39 INFO]: Copyright 2018-2023 Velocity Contributors. Velocity ist lizenziert unter den Bedingungen der GNU General Public License v3.
[23:27:39 INFO]: velocitypowered.com - GitHub

Additional Information

No response

@scrayos scrayos added the type: bug Something isn't working label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant