Resource ID changed to Asset Id in asset list #1079

beingtechsavy · 2023-04-10T15:18:43Z

Description

This is pretty much a documentation change that I made in the code where we changed the name of Resource ID to Asset ID in asset list, this makes the tag better to read and understand.

Fixes # (issue)
#1063

Type of change

This is a documentation change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Chore (no code changes)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

Test A
Test B

Checklist:

My code follows the style guidelines of this project
My commit message/PR follows the contribution guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

- corrected tagging filter for asset list API - corrected tagging filter for violation API

Chore/default local.py update

* bug:extra space character removal from db_Policy.sql file * bug:extra space character removal from db_Policy.sql file

* bug:audit policy update display name in sql and json files (cherry picked from commit cb1e298) * bug:audit policy update wiki link in resolution url in sql and json files (cherry picked from commit 4147835) * bug:policy audit changes applying to v2 * bug:policy audit changes applying to v2 * bug:policy audit changes applying to v2 * bug:policy audit changes applying to v2 * bug:policy audit changes applying to v2

* fix: changed getPolicyId API endpoint * fixed recently Viewd API and sorting in Asset List --------- Co-authored-by: ranadheer-bolli <[email protected]>

- corrected category filter for violation API - corrected tagging filter for violation API

…y and compliance overview in dashboard

Fix/db policy entries

Fix/policy param

…tion # Conflicts: # installer/resources/pacbot_app/files/DB_Policy.sql

bug: quotes missing from policy param description attribute

PaladinCloudJohn · 2023-04-10T17:00:43Z

Thanks for making this PR @beingtechsavy. I'm worried that there are unrelated changes here. Your fork may be out of date and needs to be updated, but even then 175 line changes which seem very high. Why were lines 479-537 deleted?

Also, the change to the file webapp/src/app/pacman-features/modules/compliance/policy-violations-list/policy-violations-list.component.spec.ts looks like an errant 'a' was added and would break the code.

beingtechsavy · 2023-04-11T15:13:42Z

I am looking into it.

PaladinCloudJohn · 2023-04-11T16:28:33Z

Maybe it's your editor, but I'm showing 59 different files have been changed. This change should only be impacting a single file. You may want to reset your local environment back to the master branch, make a new fork, and then copy over the name change to webapp/src/app/pacman-features/modules/assets/asset-list/asset-list.component.ts

I believe that's the only file that needs changed to complete this issue.

ranadheer-bolli and others added 30 commits February 6, 2023 09:07

fix: changed getPolicyId API endpoint

5efc9ef

chore:Cognito_bug_fix

d58a258

bug:reduce policy name and uuid size

c6b70d5

chore:Cognito_creation_after_ES_creation

1adfbe4

chore:default.local.py_update

cdac84c

fix: Tagging filters on asset and violation

eb6e9b7

- corrected tagging filter for asset list API - corrected tagging filter for violation API

Merge pull request #796 from PaladinCloud/chore/default_local.py_update

86c4415

Chore/default local.py update

bug:V2-extra space character removal from db_Policy.sql file (#802)

54eb385

* bug:extra space character removal from db_Policy.sql file * bug:extra space character removal from db_Policy.sql file

fix: bug fixes

06f6e2b

fix: fix sorting issue for column containing numbers

914a3b3

fixed sorting arrow in violations

5178b3e

fix: fixed filters for tags in violations and asset list

06d81ac

fixed server side sorting for violations list

56dda82

fix:Policy_Display_name in DB_Policy.sql

f556c85

chore/creating_cognito_user_after_es_creation

ff8af5b

fix: truncating the policy table to reflect the new changes

994304d

Fix/recently viewed api (#822)

788db7d

* fix: changed getPolicyId API endpoint * fixed recently Viewd API and sorting in Asset List --------- Co-authored-by: ranadheer-bolli <[email protected]>

fix: fixed tagging across target type widget, breadcrumbs in tagging

3583ff4

fix: Filters on asset and violation

bc1d40a

- corrected category filter for violation API - corrected tagging filter for violation API

fix: fixed Account id sorting in asset list

917477c

bug:policy audit changes

565a62e

feat: adding new fields to user params in policies

4b8cece

bug:policy audit changes for wiki links for asset group gcp and aws

a37b220

chore/cognito_azure_ad_configuration

d33e6b6

feat: added client side filters for policy-knowledgebase, admin/polic…

4c73bd3

…y and compliance overview in dashboard

fix:Policy_Display Names and Wiki links for Azure

2cf248d

Resolved merge conflict by incorporating both suggestions.

168ce2b

Merge pull request #842 from PaladinCloud/fix/DB_Policy_Entries

cac2f7e

Fix/db policy entries

bug:build db error resolution

b3da3ef

santhosh-challa and others added 23 commits March 8, 2023 12:50

Merge pull request #925 from PaladinCloud/fix/policyParam

e2e6f64

Fix/policy param

fix: fixed non responsiveness of UI

36f8b9e

fix - aws external vpc changes

5a39a93

feat: removed roleIdentifyingString from policy params

3d57b92

fix: fixed policy compliance screen and policy knowledgebase ui bugs

7fac8b7

feat: quotes missing from policy param descroption attribute

71723d1

fix: invalid json fixed

edaf680

Merge remote-tracking branch 'origin/v2.0.2' into policy_param_correc…

002b4f2

…tion # Conflicts: # installer/resources/pacbot_app/files/DB_Policy.sql

feat: quotes missing from policy param descroption attribute

2a1082d

Merge pull request #934 from PaladinCloud/policy_param_correction

e2224a6

bug: quotes missing from policy param description attribute

fix: fixed overall tagging count and individual tag count

cfd5809

refactored editpolicy screen

1faf6c6

fix:display missing categories in trend compliance api

5d6eb04

fix:include overall compliance percent in category compliance api

606070a

refactor: modified edit policy screen

22c10e0

fix: under utilize ec2,rdsdb, rediscluster policy fix

d20b658

fix: fixed edit policy and getting updated list on successful Update

aa785c8

fix:fix for NaN issue in trend compliance api

7f65a05

fix: Corrected qualys KB API URL

c2483ed

fixed multiple hits to update API

113dc41

Fix: Removed duplicate params for category and severity

1408d10

fix: Replace custom in line policy with securityAudit policy

55b501d

Resource ID changed to Asset Id in asset list

4c46c2d

PaladinCloudJohn linked an issue Apr 10, 2023 that may be closed by this pull request

Update Resource ID to Asset ID for consistency #1063

Open

beingtechsavy and others added 2 commits April 11, 2023 21:03

Merge branch 'PaladinCloud:master' into master

cfebb3b

updated

14f36ea

beingtechsavy closed this by deleting the head repository Apr 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource ID changed to Asset Id in asset list #1079

Resource ID changed to Asset Id in asset list #1079

beingtechsavy commented Apr 10, 2023 •

edited by PaladinCloudJohn

Loading

PaladinCloudJohn commented Apr 10, 2023

beingtechsavy commented Apr 11, 2023

PaladinCloudJohn commented Apr 11, 2023

Resource ID changed to Asset Id in asset list #1079

Resource ID changed to Asset Id in asset list #1079

Conversation

beingtechsavy commented Apr 10, 2023 • edited by PaladinCloudJohn Loading

Description

Type of change

How Has This Been Tested?

Checklist:

Other information:

PaladinCloudJohn commented Apr 10, 2023

beingtechsavy commented Apr 11, 2023

PaladinCloudJohn commented Apr 11, 2023

beingtechsavy commented Apr 10, 2023 •

edited by PaladinCloudJohn

Loading