Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint Config Rules Definitions Out of Sync with Drupal Core #53

Open
aXb0t opened this issue Apr 13, 2024 · 4 comments
Open

Stylelint Config Rules Definitions Out of Sync with Drupal Core #53

aXb0t opened this issue Apr 13, 2024 · 4 comments

Comments

@aXb0t
Copy link
Contributor

aXb0t commented Apr 13, 2024

I was getting a bunch of CSS linting errors like Unknown rule function-whitespace-after(...), even after syncing Stylelint version to the final branch version.

I think because we extended the core Drupal Stylelint config, we need to keep our theme Stylelint version in sync with Drupal core.

I modified my versions in web/themes/custom/alps_trips/package.json, and reinstalled everything with Yarn:

    "stylelint": "^15.7.0",
    "stylelint-config-standard": "^33.0.0",
    "stylelint-config-tailwindcss": "^0.0.7",
    "stylelint-order": "^6.0.3",

CSS Linting is working error free again.

@chrisvetek
Copy link

how do you reinstall it so that it doesn't re-overwrite those versions you mention above? i am going through the book now and have the same issues.

@aXb0t
Copy link
Contributor Author

aXb0t commented Jul 15, 2024

Hey @chrisvetek, I have been running my own fork of the project. Drupal Version 10.1.1 and stylelint 15.7 as noted.

Delete yarn.lock and run yarn clean cache possibly might help?

@chrisvetek
Copy link

chrisvetek commented Jul 15, 2024

Thanks wasn't sure if you specified the version in the yarn install command. I'll try clearing cache.

@chrisvetek
Copy link

i figured out how to get those versions via yarn add. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants