Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a linting step to CI #356

Open
pstjean opened this issue Jan 2, 2019 · 0 comments
Open

Add a linting step to CI #356

pstjean opened this issue Jan 2, 2019 · 0 comments
Labels
low
Milestone
Sprint Zelda

Comments

@pstjean
Copy link
Contributor

pstjean commented Jan 2, 2019 •
edited
Loading

CI should run ng lint
if there are errors, prevent the PR from merging
see if something like hound exists that would also leave github comments on the PR

From the Angular docs:

The default linting tool is TSLint, and the default configuration is specified in the project's tslint.json file.

Hound supports TS, so maybe just add that?
@pstjean pstjean added the low label Jan 4, 2019
@pstjean pstjean added this to the Sprint Yolanda milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low
Projects
None yet
Milestone
Sprint Zelda
Development

No branches or pull requests
2 participants
@pstjean @IcusFMagni