Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% growth over last period #323

Open
sandikbarr opened this issue Sep 28, 2018 · 6 comments
Open

% growth over last period #323

sandikbarr opened this issue Sep 28, 2018 · 6 comments
Assignees
Labels

Comments

@sandikbarr
Copy link
Contributor

In desktop view, user agent and geo data should have a column of % growth up or down from the last period for the geo region/agent/os/form factor.

@sandikbarr sandikbarr added this to the Sprint Sandi milestone Sep 28, 2018
@sandikbarr sandikbarr self-assigned this Sep 28, 2018
@kookster
Copy link
Member

kookster commented Oct 2, 2018

confirm with @farski this is still part of the design

@farski
Copy link
Member

farski commented Oct 15, 2018

That column was included in an early mockup more as a placeholder, since it was before what we knew we could get out of Castle in a performant way. I don't think we ever got to a point where it was spec'd as a requirement for v1. The new table designs allow for additional columns, so if there are any other, useful metrics we can add without sacrificing speed I'm all for that, but I'm not married to this particular stat in any way.

@sandikbarr
Copy link
Contributor Author

It's just another request to Castle of the same kind and breadth we're already making.

@farski
Copy link
Member

farski commented Oct 15, 2018

Got it. I haven't benchmarked the API recently, but I know there were some tickets about making performance improvements, so I'll have to defer to someone else how much sense it makes to make another request. I've still been getting some 20-30s/timeout requests as things are right now, but I'm not sure if the performance refactoring has happened or not. Maybe @cavis could weigh in?

@cavis
Copy link
Member

cavis commented Oct 15, 2018

Haven't looked into the performance woes yet. Probably a requirement for something like this (which will just double the slowness for those pages).

@sandikbarr sandikbarr modified the milestone: Sprint Sandi Oct 16, 2018
@kookster
Copy link
Member

Consider if we can improve perf on this with @cavis , and check with @farski on desirability

@kookster kookster modified the milestones: Sprint Sandi, Sprint Tamsin Oct 16, 2018
@sandikbarr sandikbarr removed this from the Sprint Tamsin milestone Oct 16, 2018
@sandikbarr sandikbarr added low and removed medium labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants