Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allennlp==1.0.0 support #58

Closed
KoichiYasuoka opened this issue Jun 23, 2020 · 2 comments · Fixed by #59
Closed

allennlp==1.0.0 support #58

KoichiYasuoka opened this issue Jun 23, 2020 · 2 comments · Fixed by #59
Labels
enhancement New feature or request

Comments

@KoichiYasuoka
Copy link
Contributor

Hi @tamuhey san, unofficial-allennlp-nightly seems to have outdated since allennlp==1.0.0 released last week. pip install -U allennlp destroys import_submodules of allennlp.common.util now.
@tamuhey tamuhey added the enhancement New feature or request label Jun 23, 2020
@KoichiYasuoka
Copy link
Contributor Author

Now I realize that UDify-module is hard to integrate into allennlp==1.0.0 since UDify pretrained-model was hard-encoded to allennlp 0.9.x (especially in the parameter constructor_to_call and so on). Should we wait to integrate UDify into allennlp, or take other ways with spaCy and KNP?

tamuhey added a commit that referenced this issue Jun 24, 2020
@tamuhey
closes #58 unofficial allennlp -> allennlp
082f362
@tamuhey tamuhey mentioned this issue Jun 24, 2020
Merged
@tamuhey
Copy link
Contributor

tamuhey commented Jun 24, 2020

For now, I'll try to integrate unofficial-udify to allennlp==1.0.0.
Here is the PR: tamuhey/udify#1

tamuhey added a commit that referenced this issue Jul 8, 2020
@tamuhey
support allennlp v1 (#59)
9c44707 
* closes #58 unofficial allennlp -> allennlp

* pin hydra version to manage its deps correctly

* update udify dependency

* add boto3 for poetry

* fix for tranformers >= 2.9

* refactor

* fix for jumnanpp segfault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support allennlp v1 PKSHATechnology-Research/camphr
2 participants
@KoichiYasuoka @tamuhey