Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an ExcelException object rather than a string to represent MS Excel formula errors #1605

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from
Draft

Return an ExcelException object rather than a string to represent MS Excel formula errors #1605

wants to merge 39 commits into from

Commits on Aug 4, 2020

  1. Return an ExcelException object rather than a string to represent MS … 

    …Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formula errors
    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    692c5aa View commit details
    Browse the repository at this point in the history

  2. phpcs fixes

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    7cd9acf View commit details
    Browse the repository at this point in the history

  3. phpcs fixes

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    4307e85 View commit details
    Browse the repository at this point in the history

  4. And the moral of the story: fixing one phpcs issue can actually creat… 

    …e another
    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3a9110c View commit details
    Browse the repository at this point in the history

  5. This should fix all the scrutinizer issues with the actual code, leav… 

    …ing only its problems with the unit tests... pity it doesn't recognise the validity of previous assertions in a test
    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3d96ebc View commit details
    Browse the repository at this point in the history

  6. Simplify some of our nested ifs

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    208fc1d View commit details
    Browse the repository at this point in the history

  7. Refactor of xls writer for formulae

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    ecb3c10 View commit details
    Browse the repository at this point in the history

  8. Fix phpcs issue

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    4b95bf4 View commit details
    Browse the repository at this point in the history

  9. Fix phpcs issue

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    51037e5 View commit details
    Browse the repository at this point in the history

  10. Fix exception return datatypes in Engineering functions

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    cd0ff30 View commit details
    Browse the repository at this point in the history

  11. Fix exception return datatypes in Engineering and Statistical functions

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5b84ebb View commit details
    Browse the repository at this point in the history

  12. Fix some more phpcs issues

    MarkBaker committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    a9f50a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Minor refactoring of HTML Cell writer to eliminate pass by reference

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    6b40b74 View commit details
    Browse the repository at this point in the history

  2. Eliminate some redundant code

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    5111ee9 View commit details
    Browse the repository at this point in the history

  3. Try to let scrutinizer now that we have identified object types in tests

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    640bce8 View commit details
    Browse the repository at this point in the history

  4. Ok, let's try and keep phpcs happy with our attempted hackaround for … 

    …Scrutinizer
    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    f8dc0d0 View commit details
    Browse the repository at this point in the history

  5. Seriously?!? /** is acceptable outside a method, but inside the met… 

    …hod only `/*` is allowed?!?
    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    2abec34 View commit details
    Browse the repository at this point in the history

  6. So let's see in Scrutinizer prefers this approach

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    e189a3c View commit details
    Browse the repository at this point in the history

  7. So let's see in Scrutinizer prefers this approach

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    01dd73f View commit details
    Browse the repository at this point in the history

  8. For the sake of a space

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    6b617d9 View commit details
    Browse the repository at this point in the history

  9. Scrutinizer really is pretty f***ing stupid

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    7c2c927 View commit details
    Browse the repository at this point in the history

  10. Fix some return typehinting for Date and Financial functions

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    82b4a20 View commit details
    Browse the repository at this point in the history

  11. Fix some return typehinting for Financial functions

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c70ac2f View commit details
    Browse the repository at this point in the history

  12. Fix some return type docblocks for DateTime and Financial functions

    MarkBaker committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    557277a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Excel error returns in unit tests are now ExcelException rather than … 

    …string
    MarkBaker committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    cc8a6d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Minor changes to typehinting, and a shortcut for date conversion

    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    0336b0c View commit details
    Browse the repository at this point in the history

  2. Minor tweaks to return datatype docblocks

    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    86902ff View commit details
    Browse the repository at this point in the history

  3. Minor tweaks to return datatype docblocks

    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    c73079f View commit details
    Browse the repository at this point in the history

  4. Trying to find that nice balance line between PHPStorm complaining th… 

    …at I'm not handling a thrown exception, and phpcs complaining that I have a @throws annotation in the docblock
    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    6cfd4ec View commit details
    Browse the repository at this point in the history

  5. Trying to find that nice balance line between PHPStorm complaining th… 

    …at I'm not handling a thrown exception, and phpcs complaining that I have a @throws annotation in the docblock
    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    8c0f965 View commit details
    Browse the repository at this point in the history

  6. So lets see what this achieves

    MarkBaker committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    80480bf View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Extra typehinting

    MarkBaker committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    5f31aaa View commit details
    Browse the repository at this point in the history

  2. Extra typehinting

    MarkBaker committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    332b1af View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Extra typehinting

    MarkBaker committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9741159 View commit details
    Browse the repository at this point in the history

  2. Extra typehinting

    MarkBaker committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2426c59 View commit details
    Browse the repository at this point in the history

  3. Extra typehinting

    MarkBaker committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    bf084fc View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Extra typehinting

    MarkBaker committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    839bd11 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Extra typehinting

    MarkBaker committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    bfe278b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Update NamedFormula.php (#1701)

    @rachvela94
    rachvela94 authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    464b57f View commit details
    Browse the repository at this point in the history