Standardize exceptions

[kynx]

Currently exceptions thrown by adapters are passed up to the consumer. Other abstraction libraries like flysystem convert exceptions thrown by the adapters to their own, enabling consumers to switch adapters without changing try { ... } catch { ... } blocks.

I'd suggest creating an overall ExceptionInterface to identify exceptions coming from this library, then broad classes of exceptions with codes matching the HTTP status. Something like:

• ClientException - ie a 400 error; the current DocumentNotFoundException could extend it
• ServerException - 500, 504, etc

Thoughts?

[alexander-schranz]

At current state I will not make a catch all here to just convert it to a general exception. My experience is that people find then bugs less as they don't look at the $exception->getPrevious() and report unnecessary bugs which are more related on the used Engine as to the Abstraction itself. If we have something else which is really some kind of a Domain Exception like DocumentNotFoundException we could introduce new Exception classes.

[kynx]

OK, so say there's a network problem during reindex. I'd like to log that and retry after an exponential backoff. Is there a general way to do this, or do I have to catch an adapter-specific exception?

[alexander-schranz]

@kynx I mean there is nothing which can be generalized here at current state. So yes catch all Exception or use a adapter-specific exception. There is not yet any retry mechanic implemented in SEALs reindex commands.