Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataPackageManager: PASTA should ensure download URLs are properly encoded before attempting the download #139

Open
servilla opened this issue Feb 8, 2024 · 3 comments
Assignees
Labels
bug Bug low priority Low priority

Comments

@servilla
Copy link
Collaborator

servilla commented Feb 8, 2024

PASTA should ensure download URLs are properly encoded before attempting the download.

@servilla servilla added bug Bug medium priority Medium priority EDI labels Feb 8, 2024
@servilla servilla moved this to ToDo in Consolidated Issues Feb 8, 2024
@servilla servilla moved this from ToDo to In progress in Consolidated Issues Feb 8, 2024
@servilla
Copy link
Collaborator Author

The most appropriate location for this to occur is during the initial download attempt of the data entity. In this case, the URL encoding rewrite would occur dynamically as opposed to performing the encoding and rewriting the Level-0-EML content.

@servilla
Copy link
Collaborator Author

servilla commented Feb 13, 2024

Appropriate processing sequence:

  1. Attempt download with user-provided URL, and if fails
  2. Encode URL and attempt again.

If failure occurs after second attempt (above), then a permanent failure will be registered and displayed.

Note, if the encoding becomes too onerous, just fail.

@servilla
Copy link
Collaborator Author

We should investigate whether a partial quality report can be generated if download URL failures occur, including more specific information about why the download failure occurred in the first place. Note that the first section of the quality report is only about the metadata correctness and would still provide good feedback to the user.

@rogerdahl rogerdahl added low priority Low priority and removed medium priority Medium priority labels Sep 18, 2024
@servilla servilla removed the EDI label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug low priority Low priority
Projects
Status: In progress
Development

No branches or pull requests

2 participants