Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Histogram for TASKS_RUNTIME and LATENCY #22

Open
vinayan3 opened this issue May 19, 2020 · 2 comments
Open

Customize Histogram for TASKS_RUNTIME and LATENCY #22

vinayan3 opened this issue May 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@vinayan3
Copy link

The default histogram buckets are on the order of miliseconds and seconds. For celery if you have long running tasks like re-encoding a video and then uploading gigabyte sized files it puts all the tasks in the INF bucket. A solution could be to add a config.py which lets you customize the histogram. The super nice part is that it'd be pretty easy to put the file as a ConfigMap in Kubernetes or build the container with the extra file(basically as an overlay).

I'm happy to put up a pull request for this would be useful for the community.

@pskopnik
Copy link

This would be super useful for me as well 👍

A solution could be to add a config.py which lets you customize the histogram.

I think specifying the values as a comma-separated list in the command options would suffice. A .py would only have the advantage to dynamically choose bucket values, which is probably hard to do sensibly while maintaining stable time series.

An alternative would be to use summary metrics instead or additionally to the histogram metrics.

@SharpEdgeMarshall SharpEdgeMarshall added the enhancement New feature or request label Apr 29, 2021
@toothstone
Copy link

This would be super helpful, so far there seems to be no celery exporter with such a feature.
#17 would solve this, is there a way to help getting that merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants