-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speakers are not centered in mobile view, add spacing instead of overlay expansion #33
Comments
Is this expected? does this look okay in mobile view? |
Looks ok, but it is difficult to discuss things without a PR. Please make a PR, so someone can provide input. Thanks. |
Sure @mariobehling will raise PR |
Also check input with w3 validator. |
sure will do as well. Thanks fcartegnie. |
@skarthikeyan96 I did a PR for validation fixes. Was borken html everywhere |
I ran w3c validation check again still errors are there. |
Yes, the whole set was reverted because of some local regressions you can still use my commits https://github.com/fcartegnie/vn.opentechsummit.asia |
oh okay will take a look |
Fixed the speakers display for now , have to go through the w3c validation errors |
@mariobehling Changes has been done :) #53 |
The overlay area is expanded which resulted in a 3 column speaker area. Please implement this area with space instead of padding.
Also ensure this works on mobile view.
The text was updated successfully, but these errors were encountered: