Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speakers are not centered in mobile view, add spacing instead of overlay expansion #33

Closed
mariobehling opened this issue Oct 8, 2019 · 11 comments · Fixed by #53 · May be fixed by #41
Closed

Speakers are not centered in mobile view, add spacing instead of overlay expansion #33

mariobehling opened this issue Oct 8, 2019 · 11 comments · Fixed by #53 · May be fixed by #41
Labels
bug Something isn't working

Comments

@mariobehling
Copy link
Member

The overlay area is expanded which resulted in a 3 column speaker area. Please implement this area with space instead of padding.

Also ensure this works on mobile view.

Screenshot from 2019-10-08 09-02-11

@mariobehling mariobehling added the bug Something isn't working label Oct 8, 2019
@skarthikeyan96
Copy link

@mariobehling

scrnli_10_8_2019_11-51-32 AM

Is this expected? does this look okay in mobile view?

@mariobehling
Copy link
Member Author

Looks ok, but it is difficult to discuss things without a PR. Please make a PR, so someone can provide input. Thanks.

@skarthikeyan96
Copy link

Sure @mariobehling will raise PR

@fcartegnie
Copy link
Contributor

Also check input with w3 validator.
I already had to handle earlier issues with that part which was not edited with proper tools,
there's potentially still invisible unicode sequences breaking the layout.

@skarthikeyan96
Copy link

sure will do as well. Thanks fcartegnie.

@fcartegnie
Copy link
Contributor

fcartegnie commented Oct 8, 2019

@skarthikeyan96 I did a PR for validation fixes. Was borken html everywhere
#34

@skarthikeyan96
Copy link

I ran w3c validation check again still errors are there.

@fcartegnie
Copy link
Contributor

fcartegnie commented Oct 10, 2019

I ran w3c validation check again still errors are there.

Yes, the whole set was reverted because of some local regressions

you can still use my commits https://github.com/fcartegnie/vn.opentechsummit.asia

@skarthikeyan96
Copy link

oh okay will take a look

@skarthikeyan96
Copy link

Fixed the speakers display for now , have to go through the w3c validation errors

@mariobehling

@kumuditha-udayanga
Copy link
Member

@mariobehling Changes has been done :) #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants