-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in _types.h #195
Comments
6f94e86#diff-1fca930358f9b19260308c7a36188cacL34 I don't know why, but @Im-dex, @nitrocaster, any thoughts? |
That expression is used because the std::numeric_limits::min returns for floating-point types with denormalization the minimum positive normalized value. For example:
In current codebase it would be working correct if std::numeric_limits::min was used |
So, instead of |
Yes, we can... and remove type_zero. IMO, it's absolutely useless ) |
xray-16/src/xrCore/_types.h
Line 31 in 70f130c
Is there problem with determination min values here ?
For example -std::numeric_limits::max() != std::numeric_limits::min() also for signed types.
http://en.cppreference.com/w/cpp/types/numeric_limits
Also can replace type_zero to std::numeric_limits::lowest() ?
The text was updated successfully, but these errors were encountered: