-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built binary for openvpn3 client for the new stable release of Debian (version 12 codename bookworm) #193
Comments
I contacted support about this and they told me it's planned for the v21 release. I would love to have a timeline for when this will be available if possible. |
This is not a promise. But I do hope I can manage to have a v21 release out by end of August/early September. This will definitely include Debian 12 builds. It is holiday season now, so not much will happen in July. |
Hey @dsommers do you have an update on the release timeline? This would be a lifesaver. |
The v21 release has been delayed due to work related to solve #171 as well as some issues reported in the Core library by our internal QA. Hopefully a v21 for stable distribution releases (aka LTS distros, Debian, Ubuntu LTS, RHEL/CentOS) will be ready for internal QA within 2 weeks. Since #171 has now been taken out of the v21 release, I'm already wrapping up the last outstanding issues to get a proper build and packaging done. Once QA has approved the release, it will be shipped. The v21 release will ship with an updated OpenVPN 3 Core library, which is currently going through QA now. Even though issues found by QA in this library has so far had a very small impact on OpenVPN 3 Linux (it is also used in OpenVPN Connect), there are a still a few potential issues which might affect this project as well. |
@dsommers any further work on v21? I can muddle through with old openvpn2 client, but the v3 would be great to be able to use. |
@Drizzt321 The v21 is going through QA these days. If all goes well, end of the month is the main goal for the final release. I'm pushing out fixes needed for this release in the releaseprep/v21 branch. |
@mschlachter @jim-barber-he @samiramer @Drizzt321 I've attached here the latest QA build for Debian 12. Feel free to test it if you want. Any feedback would be valuable. openvpn3_0-20230919git6361bd5-1+bookworm_amd64.deb.gz Since GitHub is picky about such attachments, you need to
|
@mleeman is also preparing a regular/official Debian package at: |
Dang, busted :-P I've added some comments in the ticket, the highlights are:
These should work for amd64/bookworm or newer; I have a compilation issue with bullseye that I need to figure out (not much of a C++ expert, got stuck at C/glib myself).
i386 compilation is also failing, didn't look into that one either. Just checkout Feel free to comment, review |
@mleeman That's really cool you're looking into this! In regards to i386 ... There are some issues on some of the C++ templates converting between C++ data types to D-Bus data types which is not really happy on 32-bit platforms. Since the wast majority of users are on 64-bit platforms, this has not been a high priority to resolve. The documentation need to be updated also, the minimum C++ standard now will be C++17; this is due to the OpenVPN 3 Core library moved to that a while back. Further, the glib2 refactoring for #171 will also require C++17. In regards to source code, we will always publish source code as tarballs as well; which includes everything needed to build with If you want, I can provide a similar development source tarball for the binary posted a bit earlier today. Please reach out to me if you see any changes on our end to make the packaging better and/or smoother. Ideally we should not need to ship our own builds as a third-party repos. And this goes both for potential packaging efforts of the OpenVPN 3 Core library as well as the OpenVPN 3 Linux project. In regards to packaging, lintian will complain about D-Bus policies being too broad. I discussed a missing feature with the upstream "dbus-daemon" developers some years ago, and got acceptance for the |
To me, it does not really matter; packaging follows (as much as possible) upstream. I have mirrored the packaging structure on the git repo; so if you tag your release in github, I can fetch the tarball from there.
If you prefer to have full/integrated tarballs that you release on your website, I can change the watch files to match. I have indeed added a number of lintian-overrides (needs to be reviewed over time), but we have a working solution atm. As for patches, I'll send the ones that are valuable to the mailing list once the dust settles. |
FYI, there is some low hanging fruit (spelling errors) that got picked up by the debian tooling https://mentors.debian.net/package/openvpn3-linux/
and
|
|
@mleeman Two quick patches fixing the openvpn3-linux typ0s ...
These are queued up for the coming v21 release. |
fine with me, I will adjust the client to use your published snapshots. Is there a page where the index can be queried of the releases, any other URL but the openvpn maintainers use this page:
But openvpn3 is not listed there.
|
@mleeman Good point on the publicity aspects of new releases. We will look into how to do that better. Perhaps a quick solution for now would be to have use this file I just now pushed out: https://swupdate.openvpn.net/community/releases/openvpn3-linux.latest If you want a different layout here, we can probably script that a bit better. The version scheme is also fairly simple. I'm going to use three "release categories":
Stable releases will be the only releases which might have a minor version, like
This In a Debian and Ubuntu LTS context, I think it would be best stay on the Let me know what you think about this. |
Let me know what you prefer and I'll reset my salsa branches to your to the release tarball instead of the one generated from github. |
Regarding 1), that sounds like the best approach to me too; I generally would like package maintainers to add as few additional patches as possible - get them upstream first. (I'm also a Fedora package maintainer, so I have some packaging experience as well) We are aligned on the "stable" versions in Debian, so nothing more to discuss there. Packaging names ... okay, so this is "complicated". But it is related to some project names:
Currently the
The intension behind these package names is that
If we would package the OpenVPN 3 Core library, that should be named The reason the Debian packaging does not have such splits as the Fedora is that I heard from a Debian maintainer many years ago that Debian generally prefers to avoid sub-packages and only use them when strictly needed. In the Fedora land, sub-packages are more often used to split out functionality which does not need to be installed to have something working. The But you are of course free to do package this project in Debian as you see fit best with the Debian packaging guidelines. |
Debian packaging (in general) does tend to use smaller sub packages. What I would propose is to:
This way, the packaging names match to some extent the ones you defined for rpm packaging. As the need arises and if it is useful, I can split off components into different packages. At the moment, I would focus on getting How does this sound? |
That sounds great! Currently the packages (and docs) in our provided releases uses the Perhaps we should move our (OpenVPN Inc provided) packaging to also use the |
In openvpn2 we use the official Debian/Ubuntu packages as base and update from that as needed for the Community releases. Once there is official Debian packaging for openvpn3 we should probably go to a similar model. |
I have an initial version, most of the code could be re-used
One lintian error popped up that will probably require me to re-package the code:
Another one I need to look into, seems to be some data that is used during a test
|
We need to come up with a solution for that license issue in the OpenVPN 3 Core library. It's essentially a public domain license, which shouldn't really be a problem - but legalese is always annoying. that Both of these issues are coming from the OpenVPN 3 Core library. |
I am searching a bit and have found e.g.
it seems to be the same source and llvm is in
while the header file says (copy):
The file in
Maybe there has been an update since the 2001-2004 version that is in the core lib? Another reference: |
Good find! Thanks a lot for your research! Will dig into this and find a better licensed version. This is anyhow something needed to be tackled in the openvpn3 repository and will need to come in the next OpenVPN 3 Core release before pulling it into this (openvpn3-linux) project. |
A bit unrelated: |
yes there is, There have been a number of iterations that improved the quality of the package itself and the licensing was also a bit of a struggle to get through (and it needed some review). Unfortunately; Debian is not what is used to be wrt the inclusion of new packages: I have uploaded the package twice to be included via mentors only to be removed again after a timeout since it no-one was willing to sponsor it. Coincidentally, I was planning to upload the package again with hopes that it would be picked up at some point. |
Is your package available somewhere (as a .deb)? |
Sure, I uploaded the bookworm backport to my opensuse account [1], once it finished publishing, you should find it here [2] [1] https://build.opensuse.org/project/show/home:den_erpel:bookworm-backports |
Thank you for making the package available. It doesn't install, however, on testing / unstable (trixie) as it depends on libtinyxml2-9 and trixie has libtinyxml2-10. (That's the one it fails on; not sure if there are more broken dependencies.) |
I will make a package available tomorrow for unstable.
…On Mon, 4 Nov 2024, 19:04 detlefla, ***@***.***> wrote:
Thank you for making the package available. It doesn't install, however,
on testing / unstable (trixie) as it depends on libtinyxml2-9 and trixie
has libtinyxml2-10. (That's the one it fails on; not sure if there are more
broken dependencies.)
—
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKXDFAAJBUYMU34K2X7KZDZ66ZLPAVCNFSM6AAAAABREIUM46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGM3TIMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@mleeman Would you mind to forward previous reject message from Debian's ftp-master to your ITP on Debian's bug tracker, and continue to work to make it in Debian unstable? I know there are some reasons you possibility doesn't agree. So make it in the public in the ITP and request for help then. |
Yeah, I'll pick it up again: I gave it a breather because of the long discussions about the licence checks. Unrelated, I had a reject on a introducing a package because it was circumventing bandwidth limitations :-) ( |
@alee-ntap The feedback of ftp-master was handled IIRC; I prepared a package (I believe just before the summer) and got it uploaded and reviewed on mentors. There was even an endorsement of a very helpful British guy; but no-one was interested in picking it up for for upload. Like I said, I'll push it again and see if I can get things rolling again... |
@mleeman Many thanks for providing the .deb! It's installable and runnable. Can't make it connect to our server yet – but this may be a local problem. |
I uploaded it once for you into NEW queue, but got rejected by ftp-master.
And I can upload it again. It would be nice to append the rejected message into your ITP. So that we can check if all the issue mentioned by ftp-master got fixed in the next try. :) |
Sorry for the delay, was caught up i n other work. Unfortunately, I fail to find the original mail from ftp-master, but the ITP [1] has remarks and replies from a couple of people, so has the discussion on mentors [2] and the RFS [3]. I uploaded a new version last week that disables the aws service at the moment (default it failed to start so it's good to get that out). I believe that most of the remarks that can be addressed, have been addressed. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904044 |
Hello everyone! I'm joining those who have tried building openvpn3-linux. In the guide, libssl1.1 is listed among the dependencies, but if I'm not mistaken, it is no longer needed (on Debian 12, for instance, the package is not found). Perhaps it should be removed? I'm eagerly waiting for libgdbuspp-dev to become available, and especially for the .deb package. |
@danterolle if you use the sources on salsa [1], you can just use the standard debian tooling; I've built it in a clean chroot a couple weeks ago for bookworm and trixie. libssl1.1 is a dependency that is generated during packaging. See the posts above for packages built for debian 12 and debian 13 [2][3]. [1] https://salsa.debian.org/erpel/openvpn3-client |
@mleeman I just had a look at your salsa tree .... that is quite outdated now, unless I looked at the wrong places. The v23 release is the latest stable release (I'm wrapping up v24 these days). Some huge and important differences ...
I believe I have applied some suggested changes from you, but I'm not up-to-date right now if anything is missing. Please bug me if there are things which could be done better - and I'll try to get things sorted out quicker. |
No, no, it is still the same one. bummer, I must have missed the releases, I'll update the tree. I'll need to have a look at the changes, but the most important ones for me at the moment are listed under DFSG changes: These require me to recreate the release tarball. |
I'll follow up on the Sparc binary ... I have a few options here. It's too late for the v24 release (I pushed out an updated master the yesterday). In regards to the unicode headers ... the LLVM versions did not work out in the Core library without more modifications in the Core library. This is on our todo list to fix. But it's a different project OpenVPN 3 Linux depends on, so it's a bit more work to complete this one. When it comes to a "watch file" for releases ... this should be possible to use: https://swupdate.openvpn.net/community/releases/openvpn3-linux.latest |
I am having a look at updating the the release of September. The most important issue atm is that the new version depends on a new library that is also not in Debian. Packaging is not a problem (done it already), but getting it in will take some time (ITP, RFS, review, ...). Only then will I be able to upload the new openvpn3-client. I'll keep on trying to get the v21 in in parallel since this one has been reviewed extensively. I can provide the working progress packages as above. The gdbuspp packages build for bookworm and trixie, so that's good.
|
Also ... v24 is being pushed out the door ... our own apt/dnf/yum repos are not yet updated (that's what's brewing right now), but source tarballs are published:
|
No worries, I'm working on getting this in Debian for a year now, not about to give up now... |
The port to debian 12 is done, the one to unstable/trixie should be a breeze now. Most work was in figuring out new Build-Depends in the chroot builds. Tomorrow, I'll clean up the commits. I need to change the
Next, I'll pull in the 24 release. For completeness, I prefer to have the official releases included in the gbp repositories. I'll call it a day. |
@mleeman Just for clarity ... Those sources I pointed at are the official release source tarballs; they are complete. I've just not announced the release yet. We have our own set of package repos in parallel to upstream Linux distro repos, the announcement will be done when those repos are updated. Here is a signed blob (with the [email protected] key, same key used in the .asc files above) with the SHA256 hashes of all the files:
|
repositories are up to date, packages built in clean chroot. https://salsa.debian.org/erpel/openvpn3-client once I am at home, my ITP will be sent by my MTA; when I have some time, I'll upload/update the versions on my OBS repositories too. Published (amd64): https://download.opensuse.org/repositories/home:/den_erpel:/bookworm-backports/Debian_12/amd64/ |
Hmm, seems as if not all replacements are done when using a different user: These 3 files have the default user:
I think this should do it, testing it now:
|
@mleeman whoops! That's an ugly mishap! I agree, that patch should fix it. Could you send a patch to the openvpn-devel mailing list with your fix? Then I'll get that applied to git master asap. |
after I get my VPN connection up and running ;-) getting this with 24, investigating
|
@mleeman Stop all the In our own .deb packaging we do this in a postinst script:
The The reason for preserving the log is for our support team to quickly get an idea how the openvpn3-linux stack has been configured when the package was installed. |
Thanks, that did the trick, I'll add it. |
The latest Debian stable release came out on the 10th of June 2023.
Currently there is no pre-built openvpn3 Debian package built for the
bookworm
distribution.This is a request for adding a new package to support this since the other .deb packages have dependencies on packages that are too old.
The text was updated successfully, but these errors were encountered: