Pass environment needed for systemd-ask-pass #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-ask-pass allows the pin to be provided by the systemd-credentials mechanism, but that requires the environment variable $CREDENTIALS_DIRECTORY to be set. Openvpn when launched by systemd does have this environment variable available, but it doesn't pass it through to systemd-ask-pass meaning that systemd-ask-pass is unable to load the pin from systemd-credentials. This change passes the $CREDENTIALS_DIRECTORY environment variable to the execed systemd-ask-pass invocation so that systemd-credentials can be used for non-interactive pin entry. Signed-off-by: William <[email protected]>
|
I won't be able to submit this to a mailing list, as I don't have a git email work flow setup. Feel free to send this on my behalf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-ask-pass allows the pin to be provided by the systemd-credentials mechanism, but that requires the environment variable $CREDENTIALS_DIRECTORY to be set. Openvpn when launched by systemd does have this environment variable available, but it doesn't pass it through to systemd-ask-pass meaning that systemd-ask-pass is unable to load the pin from
systemd-credentials.
This change passes the $CREDENTIALS_DIRECTORY environment variable to the execed systemd-ask-pass invocation so that
systemd-credentials can be used for non-interactive pin entry.
Thank you for your contribution
You are welcome to open PR, but they are used for discussion only. All
patches must eventually go to the openvpn-devel mailing list for review:
Please send your patch using git-send-email. For example to send your latest commit to the list:
For details, see these Wiki articles: