Maybe a error, on the FareAttributes Trasformer

[p4535992]

Maybe I'm wrong, but this part of the code is correct?

if (data["currency_time"]) {
    this.push({ subject: subject, predicate: "http://schema.org/priceCurrency", object : '"' + data["currency_type"] + '"' });
  }

I'm not seeing the property "currency_time" on the documentation of gtfs.
If it's correct perhaps we should add a condition, like this:

if (data["currency_time"] && data["currency_type"]) {
    this.push({ subject: subject, predicate: "http://schema.org/priceCurrency", object : '"' + data["currency_type"] + '"' });
  }

[pietercolpaert]

Indeed! That's a typo! Sorry for the late response. Can you pull request the fix?

[p4535992]

Sure, i make a pull request on the evening.

P.S. Can you update the homepage url on http://lov.okfn.org/dataset/lov/vocabs/gtfs i'm really interested on that ontology, but i can't find a link to the ontology model.

Greetings.

[pietercolpaert]

You mean include a link to http://vocab.gtfs.org?

[p4535992]

yes, sorry, i haven't think to search that on github, very stupid me.
Greetings.

2016-07-20 13:39 GMT+02:00 Pieter Colpaert [email protected]:

You mean include a link to http://vocab.gtfs.org?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE9f_KT2wZ2mYmCaj3m3Orov9beabSajks5qXgkBgaJpZM4GrqYy
.

[pietercolpaert]

No no, you can leave this open! I will do 2 things here:

• Make a clear link to http://vocab.gtfs.org from within the ontology
• merge your PR