Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable macos #365

Closed
wants to merge 11 commits into from
Closed

Unstable macos #365

wants to merge 11 commits into from

Conversation

sotger
Copy link

@sotger sotger commented Nov 23, 2024

Hi.
Unfortunately I don't know how to make pull request description.
This is my very first pull request with my folder in ././Content/OpenTournament/

@wail
Copy link
Collaborator

wail commented Dec 14, 2024

Hi Sotger,

Can you explain to me what you are trying to contribute to the project in this PR?

It's important that when you commit files to Git that you only include the files that you meant to change. This PR has 85 changed files, many of them do not seem to be ones you wanted to change, e.g.

  • NavTestLevel.umap
  • BP_Teleporter.uasset
  • BP_CharacterSpawner.uasset
  • BP_Player.uasset
  • etc.

If you change many files unintentionally this can create bugs, so we need to ensure that your PR only has commits on the necessary files.

@sotger
Copy link
Author

sotger commented Dec 14, 2024 via email

@wail
Copy link
Collaborator

wail commented Dec 14, 2024

Hi Sotger

No worries, Git / GitHub can be challenging to learn.

Git / Submitting Files

1 important thing is to only commit files you changed intentionally. Sometimes when working in Unreal some files will be changed by accident, lets say I am creating a new map TestMapExample.umap By accident I might make a change to W_HUD_Master.uasset.
When I look in the GitHub client, I can see all changed files:

image

image

In this example it is important to uncheck any files you did not want to change before commit
You should also "Discard Changes" on files if you did not mean to change them.

File Organization

Recommendation:

Level Files (.umap) should be submitted in a subfolder: Content/OpenTournament/Levels/<YourMapName>/<YourMap>.umap

Other art assets:

  • Materials: Content/OpenTournament/Materials/
    • You should create a new subfolder if you have many materials
  • StaticMeshes: Content/OpenTournament/Meshes
  • etc.

@wail wail closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants