Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/vote-decrypt: Some errors in checking votes #172

Open
r-peschke opened this issue Jan 16, 2023 · 3 comments
Open

feature/vote-decrypt: Some errors in checking votes #172

r-peschke opened this issue Jan 16, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@r-peschke
Copy link
Member

r-peschke commented Jan 16, 2023

Referring to the tests in backend https://github.com/OpenSlides/openslides-backend/blob/feature/vote-decrypt/tests/system/action/poll/test_vote.py there are some errors in the the check in the vote-service:

  1. The following errors are all errors in 1 vote, but the checker returns a poll error with state 400 and "Vote service sends HTTP 500 Internal Server Error.". This invalidates the whole poll and not only 1 vote.
    The following list refers to the tests in the backend, which has to be fixed after your changes:
class/method
VotePollCryotographicYNA  test_wrong_option_id_type_REPORT
VotePollCryotographicYNA  test_wrong_vote_value_REPORT
VotePollCryotographicY      test_wrong_data_format_REPORT
VotePollCryotographicY      test_wrong_option_id_type_REPORT
VotePollCryotographicY      test_wrong_vote_data_REPORT
VotePollCryotographicN      test_wrong_data_format_REPORT
VotePollCryotographicN      test_wrong_option_id_type_REPORT
VotePollCryotographicN      test_wrong_vote_data_REPORT
  1. simple typo: class VotePollCryotographicN Methode test_change_vote_report: In "error" it should be double instead of douple
@r-peschke r-peschke added the bug label Jan 16, 2023
@r-peschke r-peschke added this to the 4.1 milestone Jan 16, 2023
@r-peschke r-peschke linked a pull request Jan 16, 2023 that will close this issue
@r-peschke r-peschke removed a link to a pull request Jan 16, 2023
@ostcar
Copy link
Member

ostcar commented Mar 4, 2023

@r-peschke For your first issue I need more information. You say the vote service returns the status code 500. There should be a message in the response body that tells me what was going wrong. Could you tell me this body?

If there is no message in the body, then there should be a log message from the vote service.

@ostcar ostcar assigned r-peschke and ostcar and unassigned ostcar Mar 4, 2023
@r-peschke
Copy link
Member Author

main-branch merged into feature branch, but isn't ready to work with, waiting for future development.

Errors in vote-service are all vote-errors, that instead the whole poll, should only invalidate the vote.

@ostcar
Copy link
Member

ostcar commented Mar 7, 2023

Could you tell me the exact error message from the vote service?

@jsangmeister jsangmeister modified the milestones: 4.1, 4.x Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants