Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open pull requests in all related repositories after an update #23

Closed
jsangmeister opened this issue Feb 8, 2024 · 1 comment · Fixed by #25
Closed

Open pull requests in all related repositories after an update #23

jsangmeister opened this issue Feb 8, 2024 · 1 comment · Fixed by #25
Assignees
Labels
Milestone

Comments

@jsangmeister
Copy link
Contributor

After this repo has been updated, pull requests should be opened automatically in all relevant repos (currently backend, client, autoupdate and search service) which update the respective submodule. This way, it is ensured that

  1. the maintainers of the repo are informed about the changes
  2. all repos always share the same version of the meta repo (assuming that most of the time the PR can simply be merged directly), which can be checked in the main repo
  3. the overhead of updating the modules and creation of PRs is kept as low as possible.

Sometimes, manual intervention will of course be necessary, but this should be the regular case.

@jsangmeister jsangmeister added this to the 4.2 milestone Feb 8, 2024
@jsangmeister jsangmeister self-assigned this Feb 8, 2024
@jsangmeister
Copy link
Contributor Author

Open question: Should a PR be created for every new commit in the repo or only the ones changing {models|permission}.yml? If we do the latter, it will happen that e.g a dependency in the meta repo is updated and the backend updates the same dependency together with the meta repo. Then, the backend is ahead of the other service regarding the meta repo commit and all other services must be updated manually if an update should be built (which means creating PRs in every service, waiting for the CI and maybe approvals, merging it and then being abel to update the main repo). However, if we do the former, it might lead to a lot of unnecessary PRs, e.g., when dependencies get updated. For example, the autoupdate service doesn't care about an updated formatter in the meta repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant