Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all meeting specific user info (i.e. the meeting_user object) when removing a user from a meeting #2111

Open
MSoeb opened this issue Nov 3, 2023 · 2 comments · May be fixed by #2134
Open

Remove all meeting specific user info (i.e. the meeting_user object) when removing a user from a meeting #2111

MSoeb opened this issue Nov 3, 2023 · 2 comments · May be fixed by #2134
Assignees
@rrenkert @r-peschke @luisa-beerboom
Labels
bug needs discussion
Milestone
4.3

Comments

@MSoeb
Copy link

MSoeb commented Nov 3, 2023

Description: If a user with a vote delegation is deleted from a meeting, the other user which is affected still has the reference of the vote delegation.

List with vote delegations
Screenshot_20231103_133920

List with a deleted user
Screenshot_20231103_133959
with one deleted users:

Reproduction:

  1. open a meeting
  2. open settings > participants > allow vote delegation
  3. open participants > create two users > provide vote delegation to them
  4. open participants > deleted one of the users with the vote delegation
  5. check the other user -> vote delegation still active

What should happen:
If a user is deleted from a meeting, the vote delegation should be deleted from both users which are affected by it.
@MSoeb MSoeb added the bug label Nov 3, 2023
@MSoeb MSoeb added this to the 4.2 milestone Nov 3, 2023
@Elblinator Elblinator changed the title Vote Delegation: delegations still available after a user is deleted from the meeting Vote Delegation: delegations still available after a user is removed from the meeting Jan 15, 2024
@rrenkert rrenkert transferred this issue from OpenSlides/openslides-client Jan 16, 2024
@rrenkert
Copy link
Member

rrenkert commented Jan 16, 2024 •
edited
Loading

We want to remove all meeting specific data for the removed user.
@emanuelschuetze Please check if this is ok.

@peb-adr peb-adr changed the title Vote Delegation: delegations still available after a user is removed from the meeting Remove all meeting specific user info (i.e. the meeting_user object) when removing a user from a meeting Jan 16, 2024
@luisa-beerboom luisa-beerboom self-assigned this Jan 17, 2024
@luisa-beerboom luisa-beerboom linked a pull request Jan 19, 2024 that will close this issue
Draft
@luisa-beerboom luisa-beerboom mentioned this issue Jan 31, 2024
Merged
@jsangmeister
Copy link
Contributor

@rrenkert @luisa-beerboom I think we should talk about what actually needs to be removed and what should not. I don't think the current approach is feasible.

@jsangmeister jsangmeister removed their assignment Apr 24, 2024
@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrenkert rrenkert

@r-peschke r-peschke

@luisa-beerboom luisa-beerboom

Labels
bug needs discussion
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Rewrite user update to delete meeting_users if groups are emptied luisa-beerboom/openslides-backend
6 participants
@rrenkert @r-peschke @jsangmeister @Elblinator @luisa-beerboom @MSoeb