Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motion state for internal recommendations #840

Closed
jsangmeister opened this issue Feb 8, 2024 · 0 comments · Fixed by #847
Closed

Add motion state for internal recommendations #840

jsangmeister opened this issue Feb 8, 2024 · 0 comments · Fixed by #847
Assignees
Milestone

Comments

@jsangmeister
Copy link
Contributor

extracted from #816

The requirements changed a little as opposed to what was stated in the old issue. The new situation is the following:

A motion state has the new boolean flag is_internal (renamed from is_internal_recommendation - I will change this in the backend). If a motion is in state with is_internal == true, its recommendation_id should be restricted to be only visible to users with motion.can_manage. This is independent of the recommendation!

@ostcar please reevaluate how feasible this is and, if possible, implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment