Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry #401

Open
ostcar opened this issue Jan 16, 2022 · 4 comments
Open

OpenTelemetry #401

ostcar opened this issue Jan 16, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@ostcar
Copy link
Member

ostcar commented Jan 16, 2022

Instrument service for OpenTelemetry.

@ostcar ostcar added the feature label Jan 16, 2022
@ostcar ostcar added this to the 4.0 milestone Jan 16, 2022
@ostcar ostcar removed this from the 4.0 milestone Dec 13, 2022
@ostcar ostcar mentioned this issue Sep 15, 2023
@ostcar
Copy link
Member Author

ostcar commented Sep 15, 2023

@ostcar how much work would it be to update this PR? it would be nice to have OTel availble in the autoupdate service, especially for debugging things like the current poll.stop performance

Originally posted by @jsangmeister in #397 (comment)

I can look into this. One important requirement is, that the datastore-writer writes the trace-id into the messagebus. This is needed to create a relation between the backend-action-request and the autoupdate-events.

In my previous PR, I wrote a "key" span in the messagebus: https://github.com/OpenSlides/openslides-autoupdate-service/pull/397/files#diff-bc85461a4330bf9a7f24943c17dea0b71e26621b9e3e57ed8b2f8f5d1d115e24R172-R191

Does the datastore-writer currently add the span? If yes, what is the key and the format?

@ostcar ostcar added this to the 4.1 milestone Sep 15, 2023
@jsangmeister
Copy link
Contributor

I remembered implementing this in OpenSlides/openslides-datastore-service#179, but it seems like @peb-adr removed the functionality again before merging. @peb-adr do you remember why? Otherwise, I would like to re-introduce this feature as previously implemented in the PR.

@emanuelschuetze emanuelschuetze changed the title OpenTelementry OpenTelemetry Sep 26, 2023
@ostcar ostcar added the waiting Waiting for some other PR/feature; more details in comments label Sep 29, 2023
@ostcar ostcar removed their assignment Sep 29, 2023
@jsangmeister
Copy link
Contributor

Datastore issue: OpenSlides/openslides-datastore-service#260

@jsangmeister jsangmeister assigned ostcar and unassigned peb-adr Oct 17, 2023
@jsangmeister jsangmeister modified the milestones: 4.1, 4.2 Dec 12, 2023
@jsangmeister jsangmeister removed the waiting Waiting for some other PR/feature; more details in comments label Dec 13, 2023
@jsangmeister
Copy link
Contributor

@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants